Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/laramume/tav2.1 #5284

Merged
merged 6 commits into from
Mar 5, 2019
Merged

Users/laramume/tav2.1 #5284

merged 6 commits into from
Mar 5, 2019

Conversation

laramume
Copy link
Contributor

@laramume laramume commented Feb 23, 2019

added SDK for new API version v2.1. Rest API Spec

Copy link
Member

@yangyuan yangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except version and release notes.

@dsgouda
Copy link
Contributor

dsgouda commented Feb 27, 2019

Please link the rest spec PR

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the

parent e68ceb4
author Lakshmanan Ramu Meenal <laramume@microsoft.com> 1539635490 -0700
committer Lakshmanan Ramu Meenal <laramume@microsoft.com> 1551313811 -0800

# This is a combination of 2 commits.
# This is the 1st commit message:

added 2.1 preview SDK for text analytics

based on PR commanets changed the number of SDK's to one

# This is the commit message #1:

fixed test project errors

# This is the commit message Azure#2:

fixed test project errors

# This is the commit message Azure#3:

fixed test project errors

# This is the commit message Azure#4:

fixed the log errors
# This is the 1st commit message:

added SDK for version 2.1

# This is the commit message #1:

resolved build failure

# This is the commit message Azure#2:

resolved build failure

# This is the commit message Azure#3:

resolved build failure

# This is the commit message Azure#4:

resolved build failure
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great apart from a minor change

@@ -7,7 +7,7 @@
[assembly: AssemblyTitle("Microsoft Azure Cognitive Services Language Client Library")]
[assembly: AssemblyDescription("Provides API functions for consuming Microsoft Azure Cognitive Services Language APIs.")]

[assembly: AssemblyVersion("2.0.0.0")]
[assembly: AssemblyVersion("3.0.0.0")]
[assembly: AssemblyFileVersion("2.1.0.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update AssemblyFileVersion too

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Mar 5, 2019

Will merge once CIs pass

@laramume laramume changed the title Users/laramume/tav2.1 [DO NOT MERGE]Users/laramume/tav2.1 Mar 5, 2019
@laramume laramume changed the title [DO NOT MERGE]Users/laramume/tav2.1 Users/laramume/tav2.1 Mar 5, 2019
@dsgouda dsgouda merged commit 3e4e2d2 into Azure:master Mar 5, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* # This is a combination of 5 commits.
parent e68ceb4
author Lakshmanan Ramu Meenal <laramume@microsoft.com> 1539635490 -0700
committer Lakshmanan Ramu Meenal <laramume@microsoft.com> 1551313811 -0800

# This is a combination of 2 commits.
# This is the 1st commit message:

added 2.1 preview SDK for text analytics

based on PR commanets changed the number of SDK's to one

# This is the commit message Azure#1:

fixed test project errors

# This is the commit message Azure#2:

fixed test project errors

# This is the commit message Azure#3:

fixed test project errors

# This is the commit message Azure#4:

fixed the log errors

* changed the version name and package notes

* # This is a combination of 5 commits.
# This is the 1st commit message:

added SDK for version 2.1

# This is the commit message Azure#1:

resolved build failure

# This is the commit message Azure#2:

resolved build failure

# This is the commit message Azure#3:

resolved build failure

# This is the commit message Azure#4:

resolved build failure

* added SDK for version 2.1

* changed version number to 3.0.0

* updated assemblyfileversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants