-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/laramume/tav2.1 #5284
Users/laramume/tav2.1 #5284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except version and release notes.
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
Please link the rest spec PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
parent e68ceb4 author Lakshmanan Ramu Meenal <laramume@microsoft.com> 1539635490 -0700 committer Lakshmanan Ramu Meenal <laramume@microsoft.com> 1551313811 -0800 # This is a combination of 2 commits. # This is the 1st commit message: added 2.1 preview SDK for text analytics based on PR commanets changed the number of SDK's to one # This is the commit message #1: fixed test project errors # This is the commit message Azure#2: fixed test project errors # This is the commit message Azure#3: fixed test project errors # This is the commit message Azure#4: fixed the log errors
87bb245
to
53123d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great apart from a minor change
@@ -7,7 +7,7 @@ | |||
[assembly: AssemblyTitle("Microsoft Azure Cognitive Services Language Client Library")] | |||
[assembly: AssemblyDescription("Provides API functions for consuming Microsoft Azure Cognitive Services Language APIs.")] | |||
|
|||
[assembly: AssemblyVersion("2.0.0.0")] | |||
[assembly: AssemblyVersion("3.0.0.0")] | |||
[assembly: AssemblyFileVersion("2.1.0.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update AssemblyFileVersion
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will merge once CIs pass |
* # This is a combination of 5 commits. parent e68ceb4 author Lakshmanan Ramu Meenal <laramume@microsoft.com> 1539635490 -0700 committer Lakshmanan Ramu Meenal <laramume@microsoft.com> 1551313811 -0800 # This is a combination of 2 commits. # This is the 1st commit message: added 2.1 preview SDK for text analytics based on PR commanets changed the number of SDK's to one # This is the commit message Azure#1: fixed test project errors # This is the commit message Azure#2: fixed test project errors # This is the commit message Azure#3: fixed test project errors # This is the commit message Azure#4: fixed the log errors * changed the version name and package notes * # This is a combination of 5 commits. # This is the 1st commit message: added SDK for version 2.1 # This is the commit message Azure#1: resolved build failure # This is the commit message Azure#2: resolved build failure # This is the commit message Azure#3: resolved build failure # This is the commit message Azure#4: resolved build failure * added SDK for version 2.1 * changed version number to 3.0.0 * updated assemblyfileversion
added SDK for new API version v2.1. Rest API Spec