Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppConfig] Add documentation to SDK #5304

Merged
merged 5 commits into from
Mar 7, 2019
Merged

[AppConfig] Add documentation to SDK #5304

merged 5 commits into from
Mar 7, 2019

Conversation

maririos
Copy link
Member

@maririos maririos commented Mar 1, 2019

No description provided.

@maririos maririos added Client This issue points to a problem in the data-plane of the library. App Configuration Azure.ApplicationModel.Configuration labels Mar 1, 2019
@maririos maririos self-assigned this Mar 1, 2019
KrzysztofCwalina
KrzysztofCwalina reviewed Mar 1, 2019
View reviewed changes
Copy link
Member

@KrzysztofCwalina KrzysztofCwalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two small comments. Otherwise good writing!

@maririos
Copy link
Member Author

maririos commented Mar 4, 2019

FYI @AlexGhiondea and @KrzysztofCwalina I added more information about the service and what a configuration setting is following what the service team has in their docs like this and this

@maririos
Copy link
Member Author

maririos commented Mar 5, 2019

@AlexGhiondea could you give it another look?

@maririos maririos merged commit 4f4d633 into Azure:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina left review comments

@AlexGhiondea AlexGhiondea AlexGhiondea approved these changes

Assignees

@maririos maririos

Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maririos @AlexGhiondea @KrzysztofCwalina