-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Search] Generate code for the Search and ContinueSearch API #5324
[Azure Search] Generate code for the Search and ContinueSearch API #5324
Commits on Mar 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0b9e7cf - Browse repository at this point
Copy the full SHA 0b9e7cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f385d53 - Browse repository at this point
Copy the full SHA f385d53View commit details -
Removing DocumentSearchResult/SearchResult and their base classes
From now on, for dynamically-typed scenarios, callers of Search need to use DocumentSearchResult<Document> and SearchResult<Document> instead. This will make it easier to transition the implementation of this API to generated code.
Configuration menu - View commit details
-
Copy full SHA for b787b5b - Browse repository at this point
Copy the full SHA b787b5bView commit details -
[Azure Search] Remove FacetResults and HitHighlights types
This is a breaking change to facilitate more generated code in the SDK. Facet results are now typed as IDictionary<string, IList<FacetResult>> and hit highlights as IDictionary<string, IList<string>>.
Configuration menu - View commit details
-
Copy full SHA for 5536c00 - Browse repository at this point
Copy the full SHA 5536c00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cdd36a - Browse repository at this point
Copy the full SHA 5cdd36aView commit details -
[Azure Search] Clarify serialization capability of SearchContinuation…
…Token Added remarks to the comments for SearchContinuationToken that call out its ability to be serialized to and from JSON.
Configuration menu - View commit details
-
Copy full SHA for 0e85c97 - Browse repository at this point
Copy the full SHA 0e85c97View commit details -
[Azure Search] Generate code for the Search API and its model types
This change introduces new generated code and replaces most custom model class code with generated models, but it does not yet switch over the implementation of Search to use the new generated code.
Configuration menu - View commit details
-
Copy full SHA for 44f12ac - Browse repository at this point
Copy the full SHA 44f12acView commit details -
[Azure Search] Simplify how continuation tokens are constructed
This is a temporary step on the way to replacing the custom implementation of Search with generated code. This change streamlines the process of deserializing search results by: - Removing the unnecessary intermediate DocumentSearchResponsePayload class - Moving the logic to build SearchContinuationTokens into DocumentSearchResult - Passing JsonSerializerSettings to the core operation methods instead of passing lambdas Since DocumentSearchResponsePayload is gone, I also took the opportunity to make SearchContinuationTokenPayload a private nested class of SearchContinuationTokenConverter.
Configuration menu - View commit details
-
Copy full SHA for 0aef1e0 - Browse repository at this point
Copy the full SHA 0aef1e0View commit details -
[Azure Search] Replace Search implementation with generated code
Also remove functionality from SearchParameters that isn't used anymore.
Configuration menu - View commit details
-
Copy full SHA for 826d030 - Browse repository at this point
Copy the full SHA 826d030View commit details -
[Azure Search] Updating session records
Also fixing some Java-isms in a test.
Configuration menu - View commit details
-
Copy full SHA for aac990e - Browse repository at this point
Copy the full SHA aac990eView commit details -
[Azure Search] Replace ContinueSearch implementation with generated code
This required some very hacky regexes to customize the generated code, but it works. Also, it's better than having to parse URL query strings to reconstitute a SearchParameters instance, since that would miss custom parameters that can't be modeled in Swagger, like personalization IDs for custom ranking. Ideally we'll find a pattern common to other data plane APIs so we don't have to hack this with regexes for every target language, but it's good enough for now.
Configuration menu - View commit details
-
Copy full SHA for 0a9035c - Browse repository at this point
Copy the full SHA 0a9035cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 765c5fb - Browse repository at this point
Copy the full SHA 765c5fbView commit details -
[Azure Search] Refactor DocumentsOperations & make AutocompleteMode n…
…on-null Also renamed some properties for consistency.
Configuration menu - View commit details
-
Copy full SHA for ebac8e1 - Browse repository at this point
Copy the full SHA ebac8e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f65a779 - Browse repository at this point
Copy the full SHA f65a779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a58b94 - Browse repository at this point
Copy the full SHA 4a58b94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b17256 - Browse repository at this point
Copy the full SHA 3b17256View commit details -
Configuration menu - View commit details
-
Copy full SHA for e40003c - Browse repository at this point
Copy the full SHA e40003cView commit details