Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Generate code for the Search and ContinueSearch API #5324

Merged
merged 17 commits into from
Mar 8, 2019

Commits on Mar 7, 2019

  1. Configuration menu
    Copy the full SHA
    0b9e7cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f385d53 View commit details
    Browse the repository at this point in the history
  3. Removing DocumentSearchResult/SearchResult and their base classes

    From now on, for dynamically-typed scenarios, callers of Search need to use
    DocumentSearchResult<Document> and SearchResult<Document> instead. This will
    make it easier to transition the implementation of this API to generated
    code.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    b787b5b View commit details
    Browse the repository at this point in the history
  4. [Azure Search] Remove FacetResults and HitHighlights types

    This is a breaking change to facilitate more generated code in the SDK. Facet
    results are now typed as IDictionary<string, IList<FacetResult>> and hit
    highlights as IDictionary<string, IList<string>>.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    5536c00 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5cdd36a View commit details
    Browse the repository at this point in the history
  6. [Azure Search] Clarify serialization capability of SearchContinuation…

    …Token
    
    Added remarks to the comments for SearchContinuationToken that call out its
    ability to be serialized to and from JSON.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    0e85c97 View commit details
    Browse the repository at this point in the history
  7. [Azure Search] Generate code for the Search API and its model types

    This change introduces new generated code and replaces most custom model
    class code with generated models, but it does not yet switch over the
    implementation of Search to use the new generated code.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    44f12ac View commit details
    Browse the repository at this point in the history
  8. [Azure Search] Simplify how continuation tokens are constructed

    This is a temporary step on the way to replacing the custom implementation of
    Search with generated code. This change streamlines the process of
    deserializing search results by:
      - Removing the unnecessary intermediate DocumentSearchResponsePayload class
      - Moving the logic to build SearchContinuationTokens into
        DocumentSearchResult
      - Passing JsonSerializerSettings to the core operation methods instead of
        passing lambdas
    
    Since DocumentSearchResponsePayload is gone, I also took the opportunity to
    make SearchContinuationTokenPayload a private nested class of
    SearchContinuationTokenConverter.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    0aef1e0 View commit details
    Browse the repository at this point in the history
  9. [Azure Search] Replace Search implementation with generated code

    Also remove functionality from SearchParameters that isn't used anymore.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    826d030 View commit details
    Browse the repository at this point in the history
  10. [Azure Search] Updating session records

    Also fixing some Java-isms in a test.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    aac990e View commit details
    Browse the repository at this point in the history
  11. [Azure Search] Replace ContinueSearch implementation with generated code

    This required some very hacky regexes to customize the generated code, but it
    works. Also, it's better than having to parse URL query strings to
    reconstitute a SearchParameters instance, since that would miss custom
    parameters that can't be modeled in Swagger, like personalization IDs for
    custom ranking.
    
    Ideally we'll find a pattern common to other data plane APIs so we don't have
    to hack this with regexes for every target language, but it's good enough for
    now.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    0a9035c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    765c5fb View commit details
    Browse the repository at this point in the history
  13. [Azure Search] Refactor DocumentsOperations & make AutocompleteMode n…

    …on-null
    
    Also renamed some properties for consistency.
    brjohnstmsft committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    ebac8e1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f65a779 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4a58b94 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3b17256 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e40003c View commit details
    Browse the repository at this point in the history