Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Search: Regenerate management SDK to add service identity #5332

Conversation

natinimni
Copy link
Contributor

Regenerating management SDK to get latest MSI related changed from the spec

@brjohnstmsft
Copy link
Member

@natinimni Can you please provide a link to the Swagger spec PR on which this change is based?

@natinimni
Copy link
Contributor Author

Related swagger PR: Azure/azure-rest-api-specs#5319

Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the Resource and SearchService constructors, while not breaking at compile-time, are breaking changes in terms of binary compatibility, so please bump the major version number of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Mar 14, 2019

@brjohnstmsft is this ready to merge?

@brjohnstmsft
Copy link
Member

@dsgouda Yes, please merge it.

@dsgouda dsgouda merged commit 79c324a into Azure:master Mar 15, 2019
shmed pushed a commit to shmed/azure-sdk-for-net that referenced this pull request Apr 5, 2019
…e#5332)

* Azure Search: Regenerate management SDK to add service identity

* Azure search MGMTSDK: Updating tests recordings

* Addressing PR comments
shmed pushed a commit to shmed/azure-sdk-for-net that referenced this pull request Apr 6, 2019
…e#5332)

* Azure Search: Regenerate management SDK to add service identity

* Azure search MGMTSDK: Updating tests recordings

* Addressing PR comments
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
…e#5332)

* Azure Search: Regenerate management SDK to add service identity

* Azure search MGMTSDK: Updating tests recordings

* Addressing PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants