-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Search: Regenerate management SDK to add service identity #5332
Azure Search: Regenerate management SDK to add service identity #5332
Conversation
@natinimni Can you please provide a link to the Swagger spec PR on which this change is based? |
Related swagger PR: Azure/azure-rest-api-specs#5319 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the Resource and SearchService constructors, while not breaking at compile-time, are breaking changes in terms of binary compatibility, so please bump the major version number of the SDK.
src/SDKs/Search/Management/Search.Management.Tests/Tests/SearchServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@brjohnstmsft is this ready to merge? |
@dsgouda Yes, please merge it. |
…e#5332) * Azure Search: Regenerate management SDK to add service identity * Azure search MGMTSDK: Updating tests recordings * Addressing PR comments
…e#5332) * Azure Search: Regenerate management SDK to add service identity * Azure search MGMTSDK: Updating tests recordings * Addressing PR comments
…e#5332) * Azure Search: Regenerate management SDK to add service identity * Azure search MGMTSDK: Updating tests recordings * Addressing PR comments
Regenerating management SDK to get latest MSI related changed from the spec