Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HDInsight] - Update configurations #5685

Merged
merged 1 commit into from
Apr 9, 2019
Merged

[HDInsight] - Update configurations #5685

merged 1 commit into from
Apr 9, 2019

Conversation

aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Apr 4, 2019 •
edited
Loading

Hydra PR Links

Azure/hydra-specs-pr#1402: [HDInsight] - Update configurations

Rest Spec PR Links

Azure/azure-rest-api-specs#5477: [HDInsight] - Update configuration related APIs

Note

Add 3 new SDK method groups:

  1. IClusterOperations.ListConfigurationsAsync: Gets all configuration information for an HDI cluster.
  2. IClusterOperations.GetGatewaySettingsAsync: Gets the gateway settings for the specified cluster.
  3. IClusterOperations.UpdateGatewaySettingsAsync: Configures the gateway settings on the specified cluster.

@idear1203 idear1203 self-requested a review April 4, 2019 08:28
idear1203
idear1203 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dsgouda
Copy link
Contributor

dsgouda commented Apr 4, 2019

@shahabhijeet PTAL

@dsgouda
Copy link
Contributor

dsgouda commented Apr 5, 2019 •
edited
Loading

@aim-for-better Please join Azure org here
Please link the Rest spec PR too

@aim-for-better
Copy link
Member Author

@aim-for-better Please join Azure org here
Please link the Rest spec PR too

@dsgouda The Rest spec PR Link has been updated. Please see the latest comment. Thanks.

@aim-for-better
Copy link
Member Author

@aim-for-better Please join Azure org here
Please link the Rest spec PR too

@dsgouda The Rest spec PR Link has been updated. Please see the latest comment. Thanks.

And Hydra spec PR Link can be opened correctly now

@dsgouda
Copy link
Contributor

dsgouda commented Apr 8, 2019

@aim-for-better @idear1203 Why is this targeting the HyakNetCore branch?
@shahabhijeet PTAL

@idear1203
Copy link
Contributor

idear1203 commented Apr 9, 2019 •
edited
Loading 

<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>

Is assembly sign necessary? Our Swagger based SDK don't have assembly sign. You can see from here #Resolved

Refers to: src/ResourceManagement/HDInsight/Microsoft.Azure.Management.HDInsight/Management.HDInsight.csproj:15 in c204128. [](commit_id = c204128, deletion_comment = False)

@idear1203 idear1203 self-requested a review April 9, 2019 09:24
@aim-for-better aim-for-better force-pushed the HyakNETCoreAddAndDeprecatedAPI branch from d21d960 to 8b05459 Compare April 9, 2019 10:32
@aim-for-better
Copy link
Member Author 

<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>

Is assembly sign necessary? Our Swagger based SDK don't have assembly sign. You can see from here

Refers to: src/ResourceManagement/HDInsight/Microsoft.Azure.Management.HDInsight/Management.HDInsight.csproj:15 in d21d960. [](commit_id = d21d960, deletion_comment = False)

yes, it is necessary. Otherwise, while building there is error.

@aim-for-better aim-for-better force-pushed the HyakNETCoreAddAndDeprecatedAPI branch from 8b05459 to c204128 Compare April 9, 2019 11:17
@aim-for-better
Copy link
Member Author 

<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>

Yes it is necessary. Otherwise, while building there is error

In reply to: 481169757 [](ancestors = 481169757)

Refers to: src/ResourceManagement/HDInsight/Microsoft.Azure.Management.HDInsight/Management.HDInsight.csproj:15 in c204128. [](commit_id = c204128, deletion_comment = False)

idear1203
idear1203 approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shahabhijeet shahabhijeet merged commit 6293146 into Azure:HyakNETCore Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

@idear1203 idear1203 idear1203 approved these changes

Assignees

@shahabhijeet shahabhijeet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aim-for-better @dsgouda @idear1203 @shahabhijeet