Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HDInsight] - Update SDK version to 5.0.0 #5724

Merged
merged 2 commits into from
Apr 11, 2019
Merged

[HDInsight] - Update SDK version to 5.0.0 #5724

merged 2 commits into from
Apr 11, 2019

Conversation

idear1203
Copy link
Contributor

Swagger PR Links

Note

This PR aims to update SDK version from 4.4.0-preview to 5.0.0. This is the first Swagger-based HDInsight SDK with stable version number.

@idear1203 idear1203 requested a review from dsgouda April 5, 2019 23:57
dsgouda
dsgouda suggested changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOoks good for the most part

src/SDKs/HDInsight/Management/Management.HDInsight/Management.HDInsight.csproj
<PackageTags>Microsoft Azure HDInsight Management;HDInsight;HDInsight Management</PackageTags>
<PackageReleaseNotes>
<![CDATA[
This is a public preview release of the Azure HDInsight SDK. Add support for get/update gatewaysettings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if you point out the features being released in this stable version in the PackageReleaseNotes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! I have updated the PackageReleaseNotes

dsgouda
dsgouda approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Apr 8, 2019

Will merge once CIs pass

@idear1203
Copy link
Contributor Author

Please don't merge. We need to update the SDK Release note.

@dsgouda
Copy link
Contributor

dsgouda commented Apr 10, 2019

@idear1203 let us know when this is ready to merge

@idear1203 idear1203 force-pushed the hdi_update_sdk_version_to_be_stable branch from 9bb3024 to 8bccf50 Compare April 11, 2019 08:05
@idear1203
Copy link
Contributor Author

startbuild

@idear1203
Copy link
Contributor Author

@dsgouda This PR is ready to merge.

@idear1203 idear1203 force-pushed the hdi_update_sdk_version_to_be_stable branch from 8bccf50 to 42aec79 Compare April 11, 2019 08:13
@dsgouda dsgouda merged commit 27dc1a5 into Azure:master Apr 11, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@idear1203 @mentat9
[HDInsight] - Update SDK version to 5.0.0 (Azure#5724)
d3ca89f 
* [HDInsight] - Update SDK version to 5.0.0

* Update PackageReleaseNotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idear1203 @dsgouda