Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove watcher #5833

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Remove watcher #5833

merged 1 commit into from
Apr 19, 2019

Conversation

maririos
Copy link
Member

@pakrym
Copy link
Contributor

pakrym commented Apr 17, 2019

Change is fine.

I'm not sure if there is a reason to keep this implementation around at all.

@maririos
Copy link
Member Author

Having it around does suggest that we might consider using it in the future, but we just added it because the ASP.NET provider uses it, not really because it is a user scenario.

I am ok with deleting it all together. @KrzysztofCwalina what do you think?

@KrzysztofCwalina
Copy link
Member

I'm not sure if there is a reason to keep this implementation around at all

We will need it when we port the ASP.NET provider to our SDK.

@maririos maririos merged commit 85309e7 into Azure:master Apr 19, 2019
@maririos maririos deleted the watcher branch May 8, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina approved these changes

@pakrym pakrym Awaiting requested review from pakrym

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove watcher code and more it to test project
3 participants
@maririos @pakrym @KrzysztofCwalina