Do not unnecessarily pad RSA exponent length to 4 bytes #8381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
reviewed
Oct 24, 2019
| @@ -313,7 +313,7 @@ public RSA ToRSA(bool includePrivateParameters = false) | |||
| // Key parameter length requirements defined by 2.2.2.9.1 RSA Private Key BLOB specification: https://docs.microsoft.com/openspecs/windows_protocols/ms-wcce/5cf2e6b9-3195-4f85-bc18-05b50e6d4e11 | |||
| var rsaParameters = new RSAParameters | |||
| { | |||
| Exponent = ForceBufferLength(nameof(E), E, 4), | |||
| Exponent = E, | |||
| Modulus = TrimBuffer(N), | |||
There was a problem hiding this comment.
Is the trim also needed? or should that be removed too?
There was a problem hiding this comment.
Apart from copying it (mostly) from track 1, I think now that we don't let you create your own JWK it may be unnecessary. In fact, if/when we do let people create their own JWKs we could still opt not to, i.e. make sure callers provide the right buffer sizes. Seems like a much larger change we might postpone to post GA. If you agree, I can open a separate bug; or, we can fix it now.
There was a problem hiding this comment.
Fine to postpone so we can do a more in depth observation.
schaabs
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8380