Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to serializer to pick up NamedEntity SubType. #9335

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Fix to serializer to pick up NamedEntity SubType. #9335

merged 1 commit into from
Jan 7, 2020

Conversation

annelo-msft
Copy link
Member

Fixes #9251.

kristapratico
kristapratico approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maririos
Copy link
Member

maririos commented Jan 7, 2020

Could we write a test for this?
I'm looking at the tests here but it looks like it uses its own way to serialize the response https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/textanalytics/Azure.AI.TextAnalytics/tests/TextAnalyticsClientTests.cs#L120

@annelo-msft annelo-msft mentioned this pull request Jan 7, 2020
Closed
@annelo-msft annelo-msft merged commit bd5bd73 into Azure:master Jan 7, 2020
@annelo-msft annelo-msft deleted the ta-fix-9251 branch January 7, 2020 21:20
heaths added a commit to heaths/azure-sdk-for-net that referenced this pull request Jan 8, 2020
@heaths
Require resources in challenge-based authentication to use HTTPS
fbb34e5 
Fixes Azure#9335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@AlexanderSher AlexanderSher Awaiting requested review from AlexanderSher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Text Analytics] RecognizeEntities SubType property is missing (v1.0.0-preview.1)
3 participants
@annelo-msft @maririos @kristapratico