This repository has been archived by the owner on May 5, 2023. It is now read-only.
Rename dataLake.Store to datalake.Store #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Why all those files were removed and no new files were added? |
|
@kpajdzik I explained it in this PR's comment. Both dataLake.Store and datalake.Store existed in this repository. This PR is just to remove dataLake.Store and to fix the tests. |
amarzavery
suggested changes
Nov 20, 2018
ghost
mentioned this pull request
|
@amarzavery Please take another look. |
|
Since I responded to all of @amarzavery feedback, I'm going to merge this PR. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like both dataLake.Store and datalake.Store existed. On my windows machine I didn't notice, but git noticed. This removes dataLake.Store in favor of the casing used in the azure-rest-api-specs readme.nodejs.md file.
Requires #4129.