[AutoPR storagesync/resource-manager] Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking

.azure-pipelines/client.yml

@@ -2,7 +2,7 @@ trigger:
   - master
 
 variables:
-  node.version: '10.x'
+  NodeVersion: '10.x'
 
 jobs:
   - job: 'Publish'
@@ -13,8 +13,8 @@ jobs:
     steps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '$(node.version)'
-        displayName: 'Install Node.js $(node.version)'
+          versionSpec: '$(NodeVersion)'
+        displayName: 'Install Node.js $(NodeVersion)'
 
       # Reduce build time by only installing the "npm-run-all" package, which is the minimum required to run the
       # composite script commands.
@@ -46,16 +46,23 @@ jobs:
       - task: PublishBuildArtifacts@1
         displayName: 'Publish Package'
 
-  - job: 'Audit'
+  - job: 'Analyze'
 
     pool:
       vmImage: 'ubuntu-16.04'
 
     steps:
+        # sudo is required for pip install, as a console_entrypoint shim needs to be placed in bin
+      - script: |
+          pip install setuptools wheel
+          sudo pip install doc-warden
+          ward scan -d $(Build.SourcesDirectory)
+        displayName: 'Verify Readmes'
+
       - task: NodeTool@0
         inputs:
-          versionSpec: '$(node.version)'
-        displayName: 'Install Node.js $(node.version)'
+          versionSpec: '$(NodeVersion)'
+        displayName: 'Install Node.js $(NodeVersion)'
 
       # Rather than running "npm install" in the repo root, reduce build time by only installing the "npm-run-all" package,
       # which is the minimum required to run the composite script commands.
@@ -85,62 +92,62 @@ jobs:
     strategy:
       matrix:
         Linux_Node6:
-          os.name: 'Linux'
-          os.vmImage: 'ubuntu-16.04'
-          node.version: '6.x'
+          OSName: 'Linux'
+          OSVmImage: 'ubuntu-16.04'
+          NodeVersion: '6.x'
         Linux_Node8:
-          os.name: 'Linux'
-          os.vmImage: 'ubuntu-16.04'
-          node.version: '8.x'
+          OSName: 'Linux'
+          OSVmImage: 'ubuntu-16.04'
+          NodeVersion: '8.x'
         Linux_Node10:
-          os.name: 'Linux'
-          os.vmImage: 'ubuntu-16.04'
-          node.version: '10.x'
+          OSName: 'Linux'
+          OSVmImage: 'ubuntu-16.04'
+          NodeVersion: '10.x'
         Linux_Node11:
-          os.name: 'Linux'
-          os.vmImage: 'ubuntu-16.04'
-          node.version: '11.x'
+          OSName: 'Linux'
+          OSVmImage: 'ubuntu-16.04'
+          NodeVersion: '11.x'
         macOS_Node6:
-          os.name: 'macOS'
-          os.vmImage: 'macOS-10.13'
-          node.version: '6.x'
+          OSName: 'macOS'
+          OSVmImage: 'macOS-10.13'
+          NodeVersion: '6.x'
         macOS_Node8:
-          os.name: 'macOS'
-          os.vmImage: 'macOS-10.13'
-          node.version: '8.x'
+          OSName: 'macOS'
+          OSVmImage: 'macOS-10.13'
+          NodeVersion: '8.x'
         macOS_Node10:
-          os.name: 'macOS'
-          os.vmImage: 'macOS-10.13'
-          node.version: '10.x'
+          OSName: 'macOS'
+          OSVmImage: 'macOS-10.13'
+          NodeVersion: '10.x'
         macOS_Node11:
-          os.name: 'macOS'
-          os.vmImage: 'macOS-10.13'
-          node.version: '11.x'
+          OSName: 'macOS'
+          OSVmImage: 'macOS-10.13'
+          NodeVersion: '11.x'
         Windows_Node6:
-          os.name: 'Windows'
-          os.vmImage: 'vs2017-win2016'
-          node.version: '6.x'
+          OSName: 'Windows'
+          OSVmImage: 'vs2017-win2016'
+          NodeVersion: '6.x'
         Windows_Node8:
-          os.name: 'Windows'
-          os.vmImage: 'vs2017-win2016'
-          node.version: '8.x'
+          OSName: 'Windows'
+          OSVmImage: 'vs2017-win2016'
+          NodeVersion: '8.x'
         Windows_Node10:
-          os.name: 'Windows'
-          os.vmImage: 'vs2017-win2016'
-          node.version: '10.x'
+          OSName: 'Windows'
+          OSVmImage: 'vs2017-win2016'
+          NodeVersion: '10.x'
         Windows_Node11:
-          os.name: 'Windows'
-          os.vmImage: 'vs2017-win2016'
-          node.version: '11.x'
+          OSName: 'Windows'
+          OSVmImage: 'vs2017-win2016'
+          NodeVersion: '11.x'
 
     pool:
-      vmImage: '$(os.vmImage)'
+      vmImage: '$(OSVmImage)'
 
     steps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '$(node.version)'
-        displayName: 'Install Node.js $(node.version)'
+          versionSpec: '$(NodeVersion)'
+        displayName: 'Install Node.js $(NodeVersion)'
 
       # Tests depend on running "npm install" in repo root
       - task: Npm@1
@@ -157,6 +164,6 @@ jobs:
       - task: PublishTestResults@2
         inputs:
           testResultsFiles: '**/test-results.xml'
-          testRunTitle: '{os.name} Node $(node.version)'
+          testRunTitle: '{OSName} Node $(NodeVersion)'
         condition: succeededOrFailed()
         displayName: 'Publish test results'

.docsettings.yml

@@ -0,0 +1,8 @@
+omitted_paths:
+  - Documentation/*
+  - examples/*
+  - runtime/ms-rest/test/*
+  - runtime/ms-rest-azure/test/*
+  - lib/services/visualSearch/* # exception. swagger changes to generate readme.md is checked in.
+language: js
+root_check_enabled: True

lib/services/luis/authoring/.scripts/postinstall.js

@@ -0,0 +1,41 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for
+// license information.
+//
+// Code generated by Microsoft (R) AutoRest Code Generator.
+// Changes may cause incorrect behavior and will be lost if the code is
+// regenerated.
+
+const resetColor = "\x1b[0m";
+const brightColor = "\x1b[1m";
+const highlightColor = "\x1b[31m";
+
+try {
+    const invisibleCharactersLength = resetColor.length + brightColor.length + highlightColor.length;
+
+    const firstLine = `Active development of this SDK has been moved to ${highlightColor}@azure/cognitiveservices-luis-authoring${resetColor}${brightColor} package.`;
+    const secondLine = "This package is in maintenance mode and will be deprecated in July 2018.";
+    const thirdLine = "Visit https://aka.ms/azure-sdk-for-js-migration for more information.";
+
+    const framePadding = 4;
+    const adjustedFirstLineLength = firstLine.length - invisibleCharactersLength;
+    const width = Math.max(adjustedFirstLineLength, secondLine.length, thirdLine.length) + framePadding;
+    const getPaddingLength = (strLength) => width - strLength - framePadding;
+
+    const firstLinePaddingLength = getPaddingLength(adjustedFirstLineLength);
+    const secondLinePaddingLength = getPaddingLength(secondLine.length);
+    const thirdLinePaddingLength = getPaddingLength(thirdLine.length);
+    const line = "#".repeat(width);
+
+    const formatTextLine = (text, padding) => `#${" ".repeat(Math.floor(padding / 2))} ${text} ${" ".repeat(Math.ceil(padding / 2))}#`;
+
+    console.log(brightColor);
+    console.log("\n" + line);
+    console.log(formatTextLine(firstLine, firstLinePaddingLength));
+    console.log(formatTextLine(secondLine, secondLinePaddingLength));
+    console.log(formatTextLine(thirdLine, thirdLinePaddingLength));
+    console.log(line + "\n");
+    console.log(resetColor);
+} catch (err) {
+    // ignore
+}

lib/services/luis/authoring/LICENSE.txt

@@ -1,21 +1,21 @@
-The MIT License (MIT)
-
-Copyright (c) 2018 Microsoft
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+The MIT License (MIT)
+
+Copyright (c) 2019 Microsoft
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

lib/services/luis/authoring/README.md

@@ -1,48 +1,49 @@
----
-uid: azure-cognitiveservices-luis-authoring
-summary: *content
-
----
-**This SDK will be deprecated next year and will be replaced by a new TypeScript-based isomorphic SDK (found at https://github.com/Azure/azure-sdk-for-js) which works on Node.js and browsers.**
-## Microsoft Azure SDK for Node.js - LUISAuthoringClient
-
-This project provides a Node.js package for accessing Azure. Right now it supports:
-- **Node.js version 6.x.x or higher**
-
-### Features
-
-
-### How to Install
-
-```bash
-npm install azure-cognitiveservices-luis-authoring
-```
-
-### How to use
-
-#### Authentication, client creation, and listPhraseLists features as an example.
-
-```javascript
-const msRest = require("ms-rest");
-const LUISAuthoringClient = require("azure-cognitiveservices-luis-authoring");
-const token = "<access_token>";
-const creds = new msRest.TokenCredentials(token);
-const subscriptionId = "<Subscription_Id>";
-const client = new LUISAuthoringClient(creds, subscriptionId);
-const appId = ec7b1657-199d-4d8a-bbb2-89a11a42e02a;
-const versionId = "testversionId";
-const skip = 1;
-const take = 1;
-
-client.features.listPhraseLists(appId, versionId, skip, take).then((result) => {
-  console.log("The result is:");
-  console.log(result);
-}).catch((err) => {
-  console.log('An error occurred:');
-  console.dir(err, {depth: null, colors: true});
-});
-```
-
-### Related projects
-
-- [Microsoft Azure SDK for Node.js](https://github.com/Azure/azure-sdk-for-node)
+---
+uid: azure-cognitiveservices-luis-authoring
+summary: *content
+
+---
+**This SDK will be deprecated next year and will be replaced by a new TypeScript-based isomorphic SDK (found at https://www.npmjs.com/package/@azure/cognitiveservices-luis-authoring) which works on Node.js and browsers.**
+**See https://aka.ms/azure-sdk-for-js-migration to learn more.**
+## Microsoft Azure SDK for Node.js - LUISAuthoringClient
+
+This project provides a Node.js package for accessing Azure. Right now it supports:
+- **Node.js version 6.x.x or higher**
+
+### Features
+
+
+### How to Install
+
+```bash
+npm install azure-cognitiveservices-luis-authoring
+```
+
+### How to use
+
+#### Authentication, client creation, and listPhraseLists features as an example.
+
+```javascript
+const msRest = require("ms-rest");
+const LUISAuthoringClient = require("azure-cognitiveservices-luis-authoring");
+const token = "<access_token>";
+const creds = new msRest.TokenCredentials(token);
+const subscriptionId = "<Subscription_Id>";
+const client = new LUISAuthoringClient(creds, subscriptionId);
+const appId = ec7b1657-199d-4d8a-bbb2-89a11a42e02a;
+const versionId = "testversionId";
+const skip = 1;
+const take = 1;
+
+client.features.listPhraseLists(appId, versionId, skip, take).then((result) => {
+  console.log("The result is:");
+  console.log(result);
+}).catch((err) => {
+  console.log('An error occurred:');
+  console.dir(err, {depth: null, colors: true});
+});
+```
+
+### Related projects
+
+- [Microsoft Azure SDK for Node.js](https://github.com/Azure/azure-sdk-for-node)

lib/services/luis/authoring/lib/lUISAuthoringClient.d.ts

@@ -48,6 +48,7 @@ export default class LUISAuthoringClient extends ServiceClient {
   permissions: operations.Permissions;
   pattern: operations.Pattern;
   settings: operations.Settings;
+  azureAccounts: operations.AzureAccounts;
 }
 
 export { LUISAuthoringClient, models as LUISAuthoringModels };

lib/services/luis/authoring/lib/lUISAuthoringClient.js

@@ -60,6 +60,7 @@ class LUISAuthoringClient extends ServiceClient {
     this.permissions = new operations.Permissions(this);
     this.pattern = new operations.Pattern(this);
     this.settings = new operations.Settings(this);
+    this.azureAccounts = new operations.AzureAccounts(this);
     this.models = models;
     msRest.addSerializationMixin(this);
   }