Skip to content

Commit

Permalink
[AppConfig] Fix failing live pipeline (#36997)
Browse files Browse the repository at this point in the history
  • Loading branch information
YalinLi0312 authored Aug 23, 2024
1 parent ca110c9 commit 99ac866
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 11 deletions.
9 changes: 2 additions & 7 deletions sdk/appconfiguration/azure-appconfiguration/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
# Release History

## 1.7.1 (Unreleased)

### Features Added

### Breaking Changes
## 1.7.1 (2024-08-22)

### Bugs Fixed

### Other Changes
- Fixed a bug in serializing/deserializing tags filter in `ConfigurationSnapshot`.

## 1.7.0 (2024-08-15)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,11 @@ def _from_generated(cls, generated: GeneratedConfigurationSnapshot) -> "Configur
if generated.filters:
for config_setting_filter in generated.filters:
filters.append(
ConfigurationSettingsFilter(key=config_setting_filter.key, label=config_setting_filter.label)
ConfigurationSettingsFilter(
key=config_setting_filter.key,
label=config_setting_filter.label,
tags=config_setting_filter.tags,
)
)
snapshot = cls(
filters=filters,
Expand Down Expand Up @@ -519,7 +523,11 @@ def _from_deserialized(
if deserialized.filters:
for config_setting_filter in deserialized.filters:
filters.append(
ConfigurationSettingsFilter(key=config_setting_filter.key, label=config_setting_filter.label)
ConfigurationSettingsFilter(
key=config_setting_filter.key,
label=config_setting_filter.label,
tags=config_setting_filter.tags,
)
)
snapshot = cls(
filters=filters,
Expand All @@ -540,7 +548,7 @@ def _from_deserialized(
def _to_generated(self) -> GeneratedConfigurationSnapshot:
config_setting_filters = []
for kv_filter in self.filters:
config_setting_filters.append(KeyValueFilter(key=kv_filter.key, label=kv_filter.label))
config_setting_filters.append(KeyValueFilter(key=kv_filter.key, label=kv_filter.label, tags=kv_filter.tags))
return GeneratedConfigurationSnapshot(
filters=config_setting_filters,
composition_type=self.composition_type,
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ parameters:
type: object
default:
- azure-appconfiguration
- azure-appconfiguration-provider
# - azure-appconfiguration-provider

extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-tests.yml
Expand Down

0 comments on commit 99ac866

Please sign in to comment.