Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint issue in azure core #11980

Closed
changlong-liu opened this issue Jun 11, 2020 · 2 comments
Closed

lint issue in azure core #11980

changlong-liu opened this issue Jun 11, 2020 · 2 comments
Assignees
Labels
Azure.Core EngSys This issue is impacting the engineering system.

Comments

@changlong-liu
Copy link
Member

The pipeline task PyLint failed In this PR: #11949.

I found below in the task detail log:
************* Module azure.core.polling._poller
azure/core/polling/_poller.py:34: [W0611(unused-import), ] Unused Tuple imported from typing

It seems will block all PR, shall we have an urgent fix on it?

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 11, 2020
@lmazuel
Copy link
Member

lmazuel commented Jun 11, 2020

@scbedd is there a reason why pylint is failing here, and was not failing before?

@lmazuel lmazuel added Azure.Core EngSys This issue is impacting the engineering system. labels Jun 11, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 11, 2020
@scbedd
Copy link
Member

scbedd commented Jun 11, 2020

@lmazuel I spent a couple hours yesterday trying to track this down. This does not repro locally, and as far as I can tell the environment dep and python versions are identical.

Submitted a PR that has since been supplanted by Xiang, but could have unblocked CI last night with an approval and a merge. Check teams channel for further discussion.

I'm closing this issue in favor of this other issue that details the problems.

@scbedd scbedd closed this as completed Jun 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants