Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable a line throwing unused-import pylint warning #11966

Closed
wants to merge 3 commits into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jun 11, 2020

I currently have 0 idea as to why this fails in CI but not locally.

Checked

  • Python versions
  • Dependency versions compared to last succeed
  • Code Diff from last succeed

This issue is filed to follow-up on why this is being thrown. We need to get CI unblocked on such a minor issue though.

EDIT: analyze now passing with the disable. swapping to PR

@scbedd scbedd changed the title update the poller to see if error still repros Disable a line throwing unused-import pylint warning Jun 11, 2020
@scbedd scbedd marked this pull request as ready for review June 11, 2020 02:31
@scbedd
Copy link
Member Author

scbedd commented Jun 11, 2020

Whoever approves this please just hit merge.

@zooba
Copy link
Member

zooba commented Jun 11, 2020

Looks like Union is unused in that file?

@scbedd
Copy link
Member Author

scbedd commented Jun 11, 2020

@zooba you're absolutely right. I'm closing this PR as @xiangyan99 patched this in a different way. I opened this PR to provide an easy out if people needed to get around the gate on azure-core last night .

I'm still investigating the reasons WHY this suddenly started occurring though. That's covered in this issue.

@scbedd scbedd closed this Jun 11, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Dec 9, 2020
Update listHosts response to include new optional properties added for BYOK auto rotation (Azure#11966)

Co-authored-by: karuna <karkrish@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants