Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tables] Create decorator to avoid creating a client for every test #12717

Closed
seankane-msft opened this issue Jul 24, 2020 · 0 comments
Closed

[Tables] Create decorator to avoid creating a client for every test #12717

seankane-msft opened this issue Jul 24, 2020 · 0 comments
Assignees
@seankane-msft
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Milestone
[2020] October

Comments

@seankane-msft
Copy link
Member

From iscai-msft
"nit: you can create a separate decorator so you don't have to create a client in every single test. Here's an example of the code we have for TextAnalytics, and what it looks like in practice. Ping me if you have any questions about how to implement this"
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/textanalytics/azure-ai-textanalytics/tests/testcase.py#L98
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/textanalytics/azure-ai-textanalytics/tests/test_detect_language.py#L59
@seankane-msft seankane-msft added Client This issue points to a problem in the data-plane of the library. Tables labels Jul 24, 2020
@seankane-msft seankane-msft self-assigned this Jul 24, 2020
@seankane-msft seankane-msft added this to the [2020] September milestone Jul 30, 2020
@seankane-msft seankane-msft mentioned this issue Sep 29, 2020
Merged
ghost pushed a commit that referenced this issue Oct 1, 2020
@seankane-msft
Cosmos Decorator and Tests (#14114)
d4fded0 
Addresses #13226 and #12717 . Screwed up my local git so I had to create a new PR, apologies @annatisch, I will address your comments from the previous PR.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seankane-msft seankane-msft

Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Milestone
[2020] October
Development

No branches or pull requests
1 participant
@seankane-msft