Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Split Between Track1 and Track2 mgmt testing #14317

Closed
scbedd opened this issue Oct 7, 2020 · 2 comments
Closed

Resolve Split Between Track1 and Track2 mgmt testing #14317

scbedd opened this issue Oct 7, 2020 · 2 comments
Labels
EngSys This issue is impacting the engineering system.

Comments

@scbedd
Copy link
Member

scbedd commented Oct 7, 2020 •
edited
Loading

Previous tags like azure-appconfiguration_1.0.0 that we leverage to test "the world as it was" against the latest version of azure-core, hit some major bumps with the dependency on mgmt-resources.

This PR made azure-sdk-tools compatible with azure-mgmt-resources and azure-mgmt-keyvault track1/track2. However, since we use tools "as they were" in the checked-out tag that we're testing against, we need to either

  1. Pin deps on azure-mgmt-keyvault<7.0.0
  2. add msrestazure as a dev_req

I have a PR over here that does #2. I'm dis-satisfied and would like a to implement a better solution that's more future proof.
@scbedd scbedd added the EngSys This issue is impacting the engineering system. label Oct 7, 2020
@scbedd scbedd mentioned this issue Oct 7, 2020
Merged
@scbedd
Copy link
Member Author

scbedd commented Oct 7, 2020 •
edited
Loading

passing regression storage
passing regression core

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue May 13, 2021
CodeGen from PR 14317 in Azure/azure-rest-api-specs
dd6b7ae 
updating swagger to match ARM API for DirectLineSpeechChannel (Azure#14317)

* updating swagger to match ARM API for DirectLineSpeechChannel

* addressing auto-comments

* typo

* tagging cognitiveSubscriptionKey as x-ms-secret

* updating examples

* removing cognitiveSubscriptionKey from responses

Co-authored-by: Vanshika Sinha <vasinha@microsoft.com>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue May 13, 2021
CodeGen from PR 14317 in Azure/azure-rest-api-specs
1ce8c92 
updating swagger to match ARM API for DirectLineSpeechChannel (Azure#14317)

* updating swagger to match ARM API for DirectLineSpeechChannel

* addressing auto-comments

* typo

* tagging cognitiveSubscriptionKey as x-ms-secret

* updating examples

* removing cognitiveSubscriptionKey from responses

Co-authored-by: Vanshika Sinha <vasinha@microsoft.com>
@lmazuel
Copy link
Member

lmazuel commented Dec 17, 2021

I feel we have this one in control and WIP, closing

@lmazuel lmazuel closed this as completed Dec 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmazuel @scbedd