Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meaningful error message when sending empty batch to eventhub #14841

Closed
arache opened this issue Oct 28, 2020 · 4 comments
Closed

Meaningful error message when sending empty batch to eventhub #14841

arache opened this issue Oct 28, 2020 · 4 comments
Assignees
@yunhaoling
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone
[2021] March

Comments

@arache
Copy link

arache commented Oct 28, 2020

When sending empty batch to eventhub, the SDK just raised the error like below:

azure.eventhub.exceptions.EventDataSendError: Message sender failed to add message data to outgoing queue.
ErrorCodes.ClientError: Message sender failed to add message data to outgoing queue.

I believe a more clear error message would be helpful here.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 28, 2020
@kaerm kaerm added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Oct 28, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 28, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the Backlog milestone Nov 2, 2020
@KieranBrantnerMagee
Copy link
Member

Hey @arache, thanks for reaching out.

Totally reasonable ask, and I find myself wanting the clarity as much as you. (I believe we even fixed this comparable specific issue in ServiceBus just recently, so more than glad to pull this in.)

Expect to see a fix in during our next EH release, this issue will track the PR as it is produced and checked in.

@yunhaoling yunhaoling modified the milestones: Backlog, [2021] March Feb 9, 2021
@yunhaoling yunhaoling mentioned this issue Feb 9, 2021
Merged
@yunhaoling
Copy link
Contributor

hey @arache , sorry for keeping you waiting.

I did a cross-language check and think this actually should be a no-op instead of raising error when sending empty event data batch.

I had a PR out for this: #16638, let me know if you have concern on the change.

@yunhaoling yunhaoling added the blocking-release Blocks release label Feb 11, 2021
@yunhaoling
Copy link
Contributor

hey @arache, we decided to make sending empty batch being a no-op instead of raising error, we will be having a preview release next week which you could try out.

I'm closing this issue now, don't hesitate to reach out to us or re-open the issue if you have any other questions!

@arache
Copy link
Author

arache commented Mar 18, 2021

Thanks @yunhaoling , nice fix.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jun 17, 2021
CodeGen from PR 14841 in Azure/azure-rest-api-specs
9c6d2c5 
add sql tag to readme.go.md (Azure#14841)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jun 17, 2021
CodeGen from PR 14841 in Azure/azure-rest-api-specs
3566a15 
add sql tag to readme.go.md (Azure#14841)
msyyc pushed a commit that referenced this issue Jun 18, 2021
@RAY-316
[AutoRelease] t1-sql-2021-06-18-22132 (#19320)
16a364b 
* CodeGen from PR 14841 in Azure/azure-rest-api-specs
add sql tag to readme.go.md (#14841)

* version,CHANGELOG

* test

* test config

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed <601306339@qq.com>
msyyc pushed a commit that referenced this issue Jun 21, 2021
@RAY-316
[AutoRelease] t2-sql-2021-06-18-25835 (#19321)
2a373a4 
* CodeGen from PR 14841 in Azure/azure-rest-api-specs
add sql tag to readme.go.md (#14841)

* version,CHANGELOG

* test

* test config

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed <601306339@qq.com>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jul 5, 2021
CodeGen from PR 14841 in Azure/azure-rest-api-specs
a8d2dc0 
add sql tag to readme.go.md (Azure#14841)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yunhaoling yunhaoling

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
[2021] March
Development

No branches or pull requests
4 participants
@arache @kaerm @KieranBrantnerMagee @yunhaoling