Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_client_from_json_dict don't work anymore with ResourceManagementClient because of parameter change #15075

Closed
HerwigBachner opened this issue Nov 6, 2020 · 5 comments
Closed

get_client_from_json_dict don't work anymore with ResourceManagementClient because of parameter change #15075

HerwigBachner opened this issue Nov 6, 2020 · 5 comments
Assignees
@lmazuel
Labels
Azure.Core Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@HerwigBachner
Copy link

  • Package Name:azure-common, azure-mgmt-resource
  • Package Version:1.1.25, 15.0.0
  • Operating System: docker python buster 3.8
  • Python Version: 3.8

Describe the bug

The function get_client_from_dict (azure-common) with the ResourceManagementClient Class (azure-mgmt-resources) does not work anymore as it defines the needed parameter credential and cretentials like it was before version 15.x
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 6, 2020
@lmazuel
Copy link
Member

lmazuel commented Nov 9, 2020

Hi @HerwigBachner
azure-common is not compatible with the latest version of SDK that uses azure-identity protocol (like azure-mgmt-resource indeed).

We need to discuss how the migration story would go here @chlowell @jongio @johanste

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@lmazuel lmazuel added Client This issue points to a problem in the data-plane of the library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 9, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@lmazuel lmazuel self-assigned this Nov 9, 2020
@jongio
Copy link
Member

jongio commented Nov 23, 2020

@nickzhums

@lmazuel lmazuel mentioned this issue Nov 23, 2020
Closed
@nickzhums
Copy link
Contributor

cc @yonzhan @jsntcy

@mccoyp mccoyp mentioned this issue Dec 1, 2020
Closed
@lmazuel lmazuel mentioned this issue Feb 16, 2021
Closed
@mccoyp mccoyp mentioned this issue Feb 17, 2021
Closed
@lmazuel
Copy link
Member

lmazuel commented Mar 12, 2021

We discussed on our team and concluded we do not want to support the JSON or file factory for security purposes, and we don't want to encourage practices that feel unsecure.
We wrote a migration guide for scenario:
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/identity/azure-identity/migration_guide.md

Please let me know any feedback or questions related to this.

@lmazuel lmazuel added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Mar 12, 2021
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Mar 20, 2021
@ghost
Copy link

ghost commented Mar 20, 2021

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ghost ghost closed this as completed Apr 3, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jul 6, 2021
CodeGen from PR 15075 in Azure/azure-rest-api-specs
5d268d5 
extract AutomationRules to new file (Azure#15075)

* extract AutomationRules to new file

* fix errors

* change ResourceWithEtag

* update readme

* change resource and subscriptionId

* add bracket

* .

* .

* .

* revert common definitons

* .
@jiasli jiasli mentioned this issue Sep 1, 2021
Merged
@jiasli jiasli mentioned this issue May 7, 2022
Open
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmazuel lmazuel

Labels
Azure.Core Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lmazuel @jongio @HerwigBachner @nickzhums