Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt to Arm Template strategy for Azure Eventgrid #15967

Closed
rakshith91 opened this issue Jan 4, 2021 · 1 comment · Fixed by #19262
Closed

Adopt to Arm Template strategy for Azure Eventgrid #15967

rakshith91 opened this issue Jan 4, 2021 · 1 comment · Fixed by #19262
Assignees
@rakshith91
Labels
Client This issue points to a problem in the data-plane of the library. Event Grid Messaging Messaging crew
Milestone
[2021] July

Comments

@rakshith91
Copy link
Contributor

Currently, there are a lot of env variables in eventgrid tests.yml

Use the arm template instead to reduce maintainance.

To add a deployment of arm templates you'll need a test-resources.json file and parameter DeployArmTemplate: true to your tests.yml file. The former you can probably take from the .NET/JS/Java sdks.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 4, 2021
@rakshith91 rakshith91 self-assigned this Jan 4, 2021
@rakshith91 rakshith91 added Client This issue points to a problem in the data-plane of the library. Event Grid labels Jan 4, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 4, 2021
@rakshith91 rakshith91 added this to the [2021] February milestone Jan 4, 2021
@lmazuel lmazuel modified the milestones: [2021] February, [2021] March Jan 4, 2021
@lmazuel
Copy link
Member

lmazuel commented Jan 4, 2021

Not GA required, I moved that to March milestone

@rakshith91 rakshith91 modified the milestones: [2021] March, [2021] April Mar 1, 2021
@rakshith91 rakshith91 modified the milestones: [2021] April, Backlog Mar 11, 2021
@lmazuel lmazuel added the Messaging Messaging crew label Apr 12, 2021
@lmazuel lmazuel modified the milestones: Backlog, [2021] June May 18, 2021
@yunhaoling yunhaoling modified the milestones: [2021] June, [2021] July Jun 14, 2021
@rakshith91 rakshith91 mentioned this issue Jun 15, 2021
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Sep 10, 2021
@aditimalladi
CodeGen from PR 15967 in Azure/azure-rest-api-specs
ddf5959 
Add Microsoft.ExtendedLocation [CustomLocation] 2021-08-15 stable API Version (Azure#15967)

* Add 2021-08-15 stable API Version

* Update Patch Properties to add identity

* Typo

* Prettier check

Co-authored-by: Aditi <amalladi@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakshith91 rakshith91

Labels
Client This issue points to a problem in the data-plane of the library. Event Grid Messaging Messaging crew
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

Adapt EG to arm template rakshith91/azure-sdk-for-python
3 participants
@lmazuel @rakshith91 @yunhaoling