Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[translation] user study + renames #17483

Closed
10 tasks done
kristapratico opened this issue Mar 22, 2021 · 0 comments
Closed
10 tasks done

[translation] user study + renames #17483

kristapratico opened this issue Mar 22, 2021 · 0 comments
Assignees
@kristapratico
Labels
Cognitive - Translator
Milestone
[2021] July

Comments

@kristapratico
Copy link
Member

kristapratico commented Mar 22, 2021 •
edited
Loading

Action items:

  • Reconsider the main scenario for translation and whether it should instead return a poller. If the P90 <= 2 docs and time from submission to completion <15 sec then an LRO makes sense. Understand from service team why the service is optimized for queueing many jobs/documents since this does not fit the common use case stated. Note that if we make this change, some of the below items are obsolete. Issue: [translation] consider poller design #17915
  • rename DocumentStatusResult.translate_to --> translated_to
  • Improve documentation for create_translation_job. This should include info about how it starts the job but that wait_until_done must be used to complete the job
  • Rename variables in samples that say job_result. This result suffix made people think the job was already finished
  • Fix the ItemPaged references in docs so that they show that it's an ItemPaged[DocumentStatusResult] etc
  • Check that we have a link in the README that links to the service docs about how to create the SAS URLs
  • Reconsider the model names TranslationStatusResult and DocumentStatusResult. People saw "status" in the name and assumed that a string was returned, not an object. Tracked in [translation] renames #19257
  • Overload the input to create_translation_job to be more friendly in the single document scenario. Effectively option 1 in this issue: [translation] consider simplifying input to translation #17916
  • Reconsider the naming of inputs to begin_translation. Perhaps this should be actions to align with TA and then the input object, DocumentTranslationInput should be called something like DocumentTranslationAction.
  • Reconsider the utility of has_completed. People thought that this attribute would get updated when accessed, when reality it's just doing a completion check on the status strings
@kristapratico kristapratico modified the milestones: [2021] May, [2021] June May 24, 2021
@kristapratico kristapratico mentioned this issue Jun 3, 2021
Merged
@kristapratico kristapratico changed the title [translation] user study [translation] user study + renames Jun 8, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Feb 16, 2022
@xwang971 @Juliehzl
@vturecek @vinisoto @erich-wang @vusause @sanchitmehta
CodeGen from PR 17820 in Azure/azure-rest-api-specs
943b397 
Microsoft.App version 2022-01-01-preview (Azure#17820)

* New Swagger Spec File

* New Swagger Example Spec File

* New Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Go Language Readme Config File

* New Python Language Readme Config File

* New Typescript Language Readme Config File

* New C# Language Readme Config File

* Adding new API version 2022-01-01-preview for the new service Microsoft.App (Azure#17135)

* Adding swagger and examples

* Fix samples

* Fix linting errors

* fix errors

* fix more errors

* prettier fixes

* Fix the VNET properties

* fix the vnet props

* Attempt to remove x-ms-identifiers

* Add x-ms-identifiers back

* Revert "Add x-ms-identifiers back"

This reverts commit 44525ab5ace45d9cb1bc85bee2751f015dcaffc6.

* Addsourcecontrolapis (Azure#17287)

* add sourcecontrol apis

* remove space

* prettier fix

* typo

* avocado fix

* lint fix

* add replicas apis (Azure#17501)

* Remove Dapr components from ContainerApp spec. Not breaking because the version hasn't been released yet. (Azure#17479)

* Remove dapr components from the ContainerApp object

* Fix example

* add descriptions

* fix

* change the auto-rest parameters

* Support volume mounts for containerApp (Azure#17530)

* add volume mounts

* add identifier

* refine volume definition

* Fix samples (Azure#17534)

* Adding managed identity (Azure#17569)

* Adding managed identity

* prettier fix.

* Microsof.app 2022 01 01 preview/add custom domains (Azure#17385)

* add support for Custom domains and certificates

* add Certificates

* Ccertificate as child resource of Managed Env.

* Support default custom domain

* PUT/DELETE certificate are not long-running

* Add Custom Domain Verification Id

* domains for all revisions and adding examples

* missing examples

* one more missing example

* Examples+missing paths

* Adding missing envelope properties

* Addressing PR comments

* Removing AKV and Free cert related properties

* Prettier and semantic validation fixes

* Fixing semantic validations and examples

* More fixes

* Addressing more PR comments

* Updating examples

* fixing type

* fixing types

* Extra properties and responses

* misplaced response

* whitespace

* fix security section

* fixing ManageEnvironment securityDefinitions

* add 204 delete response

* Removing virtual IP and IP Based option

* change modelAsString

* Addressing ARM PR comments

* Removing 404 response from example

* renaming custom hostname analysis operation

* mark certificate as tracked resource

* fix sample

* Use Certificate Id instead of Certificate name

Co-authored-by: Ruslan Yakushev 🚴 <ruslany@microsoft.com>
Co-authored-by: vinisoto <vinisoto@hotmail.com>

* Add new properties for ContainerApp (Azure#17483)

* add ephemeral storage

* add outbound ip

* add listsecrets

* fix CI

* fix example

* fix

* add identifier

* fix

* add example

* mars as secret

* Add storages operation for managedEnvironment (Azure#17545)

* add storage

* fix

* fix typo

* Add EasyAuth configuration APIs for ContainerApp (Azure#17492)

* Add Easy Auth Config related APIs for ContainerApp

* Use common type ProxyResource

* Update description

* update per validation

* typo fix

* fix validation error

* Update sample and description

* Update because ARM prefer string than boolean

* Add static web identity provider

* Add container probes (Azure#17535)

* Add container probes

* minor fix

* Use execute instead of exec'd, add identifier

* remove exec from preview

* use integer instead of intorstring

* Add `internal` property under VnetConfiguration for internalOnly environments (Azure#17656)

* Add internal property under VnetConfiguration for internalOnly environments

* Update examples

* Add Dapr Components collection APIs (Azure#17552)

* Add daprComponents

* update readme

* Fix linting errors

* More lint fixes

* prettier fixes

* make dapr component a tracked resource

* fix the patch

* fix lint errors

* Revert "fix lint errors"

This reverts commit 045f1d94bddf3527eab98b7a376070ab30fdd760.

* Revert "fix the patch"

This reverts commit 14521103e848e09762185f832c0270c16ed16efd.

* Revert "make dapr component a tracked resource"

This reverts commit 239268eda070ff37f26e8a772adacdd26bbf0937.

* Fix linter issues

* fix wrong fix

* fix linter

* fix the operationids (Azure#17809)

* correct resource name (Azure#17846)

* Add custom open id providers support (Azure#17855)

* Add custom open id providers support

* Update description

Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
Co-authored-by: Vini Soto <18271663+vinisoto@users.noreply.github.com>
Co-authored-by: vinisoto <vinisoto@hotmail.com>
Co-authored-by: erich-wang <eriwan@microsoft.com>
Co-authored-by: Mike Vu <mdhvu@uwaterloo.ca>
Co-authored-by: Sanchit Mehta <sanmeht@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kristapratico kristapratico

Labels
Cognitive - Translator
Projects
None yet
Milestone
[2021] July
Development

No branches or pull requests
2 participants
@mshaban-msft @kristapratico