Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait_for_completion in environment.py does not wait for 'Queued' state #20223

Closed
robert4os opened this issue Aug 11, 2021 · 9 comments
Closed

wait_for_completion in environment.py does not wait for 'Queued' state #20223

robert4os opened this issue Aug 11, 2021 · 9 comments
Assignees
@bandsina
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning ML-CoreUI AreaPath needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@robert4os
Copy link

  • Package Name: azure.ml.core.environment
  • Package Version: 1.33.0
  • Operating System: Linux
  • Python Version: 3.6

Describe the bug

wait_for_completion in environment,py does not wait for 'Queued' but only a few of all possible states. This is unexpected behavior.
while status in ('Running', "GettingOrProvisioningACR"):
The similar function wait_for_completion on Run implements this more stable by using 'RunStatus.get_running_statuses()' for all states a Run could be in.

To Reproduce

fill up the queue

_build = env.build(ws, image_build_compute=compute_target)
_build = env.build(ws, image_build_compute=compute_target)
_build = env.build(ws, image_build_compute=compute_target)

wait for queued build

_build = env.build(ws, image_build_compute=compute_target)
_build.wait_for_completion()

Expected behavior

wait should not exit on queued builds, but rather wait until completion (as in the func name)
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 11, 2021
@robert4os robert4os changed the title wait_for_completion in environment,py does not wait for 'Queued' state wait_for_completion in environment.py does not wait for 'Queued' state Aug 11, 2021
@swathipil swathipil added bug This issue requires a change to an existing behavior in the product in order to be resolved. ML-CoreUI AreaPath Service Attention Workflow: This issue is responsible by Azure service team. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Aug 11, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 11, 2021
@swathipil
Copy link
Member

@robert4os - thanks for opening an issue! Routing this to the correct people.

@SaurabhSharma-MSFT
Copy link
Member

SaurabhSharma-MSFT commented Nov 15, 2021 •
edited
Loading

@robert4os Apologies for the delayed response. I see that this issue is opened long time ago and no further activity had taken place. So wanted to check if you are still facing this issue ? Please let us know .

@SaurabhSharma-MSFT SaurabhSharma-MSFT added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Nov 15, 2021
@robert4os
Copy link
Author

@SaurabhSharma-MSFT Was the bug fixed then? Since the code is not open source, it is not straight forward to check. Our workaround was to write our own waiting method to wait for the correct Return state.

@ghost ghost removed the needs-author-feedback Workflow: More information is needed from author to address the issue. label Nov 16, 2021
@xiangyan99 xiangyan99 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Dec 3, 2021
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 10, 2021
@ghost
Copy link

ghost commented Dec 10, 2021

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@robert4os
Copy link
Author

What more feedback could I provide? Since the code is not open source, it is not straight forward to check.

@ghost ghost removed needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. labels Dec 14, 2021
@xiangyan99
Copy link
Member

@azureml-github

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Sep 14, 2022
@chetmaddula @sarahrahman34 @akashpargat
CodeGen from PR 20223 in Azure/azure-rest-api-specs
9dbc8f4 
[Compute] New Api Version 2022-07-02 (Azure#20223)

* New Api version 2022-07-02

* readme changes

* version update

* Adding diskControllerTypes and optimizedForFrequentAttach to resources (Azure#19958)

* add new api version

* add examples for optimizedForFrequentAttach

* adding diskcontrollertypes

* adding example and removing unknown characters

* removing unknown character

* removing null

* updating description

* Fix examples and readme

* fix based on target branch

* add examples

* remove bad files

* fix readme

* fix description for property

* adding nvme to customwords.txt

* Updating comment on NVME feature

* Fixed swagger bugs (#4)

* Fixed swagger bugs

* Addressed comments

* Updated description

* Added performancePlus property

* Updated description for performance plus

* Addressed comments

* Removed read Only property

Co-authored-by: akashpargat <akashpargat@microsoft.com>

Co-authored-by: Sarah Rahman <sarahrahman@microsoft.com>
Co-authored-by: Akash Pargat <akashpargat@yahoo.com>
Co-authored-by: akashpargat <akashpargat@microsoft.com>

* Readme.md correction

* Adding examples

* fix syntax

* update  common.json to common-types folder

* example fixes

* fix snapshot example

Co-authored-by: chetmaddula <57730350+chetmaddula@users.noreply.github.com>
Co-authored-by: Sarah Rahman <sarahrahman@microsoft.com>
Co-authored-by: Akash Pargat <akashpargat@yahoo.com>
Co-authored-by: akashpargat <akashpargat@microsoft.com>
Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
@xiangyan99
Copy link
Member

We released track 2 machine learning library https://pypi.org/project/azure-ai-ml/. Could you help to check if this works for you?

@xiangyan99 xiangyan99 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Jun 16, 2023
@github-actions github-actions bot removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jun 16, 2023
@github-actions
Copy link

Hi @robert4os. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@github-actions
Copy link

Hi @robert4os, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jun 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bandsina bandsina

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning ML-CoreUI AreaPath needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@robert4os @bandsina @xiangyan99 @SaurabhSharma-MSFT @swathipil