Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] work items for async preview #22043

Closed
11 tasks done
simorenoh opened this issue Dec 7, 2021 · 10 comments
Closed
11 tasks done

[Cosmos] work items for async preview #22043

simorenoh opened this issue Dec 7, 2021 · 10 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos

Comments

@simorenoh
Copy link
Member

simorenoh commented Dec 7, 2021

This issue will be used to track work items that should be completed while the async client is in preview mode. Any item with a checkmark will have its PR as a comment below as well.

  • Move the asynchronous client away from using **kwargs to align with python3 best design practices
  • Remove support for Python2 - RELEASED b2
  • Add warning to sync client's populate_query_metrics flag if used in methods that don't need it and remove from documentation
  • Deprecate read_offer in the sync api to align with read_throughput renaming in async client (Cosmos no longer references Offers in public docs as opposed to Throughput - may confuse users trying to use these functionalities)
  • Undocument/ remove documentation around build_options, cosmos_client_connection, connection_retry_policy for both clients - objects need to be private. For this one, add samples to show how a user might pass in retry/ policy config values as opposed to object instance
    • Will have to split this one into individual efforts for each since some cover a lot of area within the SDK
  • Transition into using python3 typehints for async client
  • GetAuthorizationHeader documentation should be removed from sync client and then made private, also bring in method with proper naming to not create breaking changes.
    • This method is being used both in tests and in samples for non-partitioned container operations using rest API, in order to remove usages of the method these tests/samples would have to be removed too
  • Verify and split proof GONE status code for partition key refresh - RELEASED SYNC b2, ASYNC b3
  • Edit async client user agent to be different for ease of use when debugging - RELEASED b2
  • before we go GA we should make most of these files in aio directory private
  • [Cosmos] move is_system_key logic to be computed only once on container usage #23169 - RELEASED b4
@simorenoh simorenoh added Cosmos Client This issue points to a problem in the data-plane of the library. cosmos-v4-python labels Dec 7, 2021
@simorenoh
Copy link
Member Author

simorenoh commented Dec 27, 2021

Split proof sync client queries: #22237 - RELEASED IN b2

@simorenoh
Copy link
Member Author

simorenoh commented Dec 27, 2021

Split proof async client queries: #22261 - RELEASED IN b3

@simorenoh
Copy link
Member Author

simorenoh commented Dec 27, 2021

Deprecate read_offer in clients to align with read_throughput renaming: #22262

@simorenoh
Copy link
Member Author

simorenoh commented Dec 27, 2021

Edit async client user agent to be different for ease of use when debugging: #22263 - RELEASED IN b2

@simorenoh
Copy link
Member Author

Add warning to sync client's populate_query_metrics flag if used in methods that don't need it and remove from documentation: #22264

@simorenoh
Copy link
Member Author

simorenoh commented Dec 30, 2021

Transition into using python3 type hints for async client: #23933
also includes changes for moving the asynchronous client away from using **kwargs to align with python3 best design practices

@simorenoh
Copy link
Member Author

GetAuthorizationMethod documentation should be removed and then made private with proper method naming: #22284

@simorenoh
Copy link
Member Author

simorenoh commented Jan 12, 2022

Remove support for Python2: #22475 - RELEASED IN b2

@simorenoh
Copy link
Member Author

Move is_system_key logic: #23821 - RELEASED IN b4

@simorenoh
Copy link
Member Author

simorenoh commented Apr 12, 2022

Undocument/ remove documentation around build_options, cosmos_client_connection, connection_retry_policy for both clients: #23945
All of the methods and classes mentioned are already private, live in a private class, or are marked for deprecation with the PR above.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos
Projects
None yet
Development

No branches or pull requests

1 participant