[Cosmos] Connection Retry Policy samples #23945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing connection retry policy from public view
rewriting some code for the cosmos client both sync and async
retry config samples for both sync and async
ghost
added
the
simorenoh
requested changes
Apr 12, 2022
simorenoh
requested changes
Apr 12, 2022
added more retry options and added more sample comments.
cosmos client reworks for both sync and async
initializing async client with context manager
annatisch
reviewed
Apr 12, 2022
simorenoh
requested changes
Apr 12, 2022
reverting changes
updating comments in the samples
adding deprecation for retry option
JericHunter
changed the title
deprecation added for connection retry policy
JericHunter
requested review from
kushagraThapar,
simplynaveen20 and
xinlian12
as code owners
indentation fix
changelog additions
simorenoh
reviewed
Apr 12, 2022
Co-authored-by: Simon Moreno <30335873+simorenoh@users.noreply.github.com>
11 tasks
whitespace error fix
…-for-python into jh-retry_configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created samples for retry config on both sync and async clients. The sample shows user how to pass in Connection Retry Policy options.
Deprecated the options 'connection_retry_policy' and 'retry_options' in the sync client.
There are some small code reworks in the cosmos_client.py file in both sync and async clients.
All SDK Contribution checklist:
General Guidelines and Best Practices