Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-template to remove extraneous requirements #12770

Closed
wants to merge 4 commits into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jul 28, 2020

The additional config items weren't being used by any automation.

}

$attempts += 1
Invoke-RestMethod -Uri $url -Body $body -Headers $headers -Method "Post" -MaximumRetryCount 3 -RetryIntervalSec 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done in azure-sdk-tools to avoid getting overriden?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure how these changes made it in, give that I reset to local master. :/ Re-working.

Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only question is about changes in the script in eng/common

@scbedd
Copy link
Member Author

scbedd commented Jul 28, 2020

Closing to re-open after force-pushing this branch.

@scbedd scbedd closed this Jul 28, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 4, 2021
add industry and locations to armTemplate API (Azure#12770)
00Kai0 added a commit that referenced this pull request Feb 19, 2021
* CodeGen from PR 12770 in Azure/azure-rest-api-specs
add industry and locations to armTemplate API (#12770)

* test,version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants