Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared #12883

Merged
merged 15 commits into from
Aug 7, 2020
Merged

Remove shared #12883

merged 15 commits into from
Aug 7, 2020

Conversation

seankane-msft
Copy link
Member

Fixes #12785
Collapses the shared directory and decreases the number of files. Deletes any unused functions or variables

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks really good, you'll notice that p much all of my comments are nits. thanks so much for doing this!

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much ready to approve, just a couple tiny changes

sdk/tables/azure-data-tables/azure/data/tables/_error.py Outdated Show resolved Hide resolved
error_message = storage_error.message
additional_data = {}
try:
error_body = ContentDecodePolicy.deserialize_from_http_generics(storage_error.response)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to confirm whether this step was necessary for errors raised by Tables?
Before and after the swagger update from Connie's PR?

sdk/tables/azure-data-tables/azure/data/tables/_models.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/_models.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/_models.py Outdated Show resolved Hide resolved
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seankane-msft seankane-msft merged commit dbe3301 into Azure:master Aug 7, 2020
@seankane-msft seankane-msft deleted the remove_shared branch August 7, 2020 19:56
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 19, 2021
Add pipeline policy and Elapsed Time Metric (Azure#12883)

* Add pipeline policy and ElapsedTime Policy

* adding missing objects

* fix schema validation

* fix prettier issues

Co-authored-by: Kalyan C Kesireddy <kalyanke@microsoft.com>
00Kai0 pushed a commit that referenced this pull request Feb 26, 2021
* CodeGen from PR 12883 in Azure/azure-rest-api-specs
Add pipeline policy and Elapsed Time Metric (#12883)

* Add pipeline policy and ElapsedTime Policy

* adding missing objects

* fix schema validation

* fix prettier issues

Co-authored-by: Kalyan C Kesireddy <kalyanke@microsoft.com>

* test,version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Kalyan C Kesireddy <kalyanke@microsoft.com>
Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of _shared folder
4 participants