Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Schema Registry + Avro Serializer] 1.0.0b1 #13124
[Schema Registry + Avro Serializer] 1.0.0b1 #13124
Changes from all commits
56bf5eb
d1c96f9
6311e92
0096ef2
2e95001
2e8bcc7
6248ff1
f97478e
3cf6459
58fb59f
02c60ec
85d6766
5fa4b43
b910027
6b6c8b2
c465be1
63a278c
dc363f4
740de0e
7734c42
92cd385
1c60676
f20bba0
c81f16b
41ee64b
2675331
fb0e6f9
0260ea3
bb687cb
d8e0986
b91fb4f
929ee68
8fbed90
01a39a7
bde3c24
a2903b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got feedback from cala; we're not supposed to have samples in these sections, we could make it a formal sample and link to it however, which is what I've leaned towards. Feel free to eyeball my current SB PR for an example of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity, I would add another quick code block for EventHub usage, since it's the main planned usage (to connect the dot). Something really simple, with a "Look at EH doc for more details about EH"
I would make it a difference code block to be sure people would not assume this package is EH specific somehow