-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added get file range with the prevsharesnapshot parameter #13507
Merged
tasherif-msft
merged 20 commits into
Azure:feature/storage-stg74
from
tasherif-msft:get-file-ranges-feature
Sep 30, 2020
Merged
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3b36965
added feature
tasherif-msft cea6275
fixed var name
tasherif-msft 8a11235
added unit test that is still being worked on
tasherif-msft 379288a
added unit test for get file range with snapshot
tasherif-msft 55708ea
added recording of the unit test
tasherif-msft e4b6100
added async unit test recording
tasherif-msft 65073b0
[Swagger][FileShare]Regenerate for Clear Range Change
xiafu-msft 61d9081
Merge branch 'stg74-share-swagger' of github.com:xiafu-msft/azure-sdk…
tasherif-msft 50e6a7f
added a deserialize method
tasherif-msft 7f288f7
recoreded new tests and added deserialize
tasherif-msft 85f4198
rerecorded
tasherif-msft 7af74c6
recorded some more
tasherif-msft e906ffb
changed tests for sync
tasherif-msft d3ffaa6
recorded async tests
tasherif-msft bb108f0
added more docstrings
tasherif-msft de893c4
linter
tasherif-msft caccc44
added additional api
tasherif-msft 1bfe833
linter
tasherif-msft 00e5e55
unused import linter
tasherif-msft bbd3d40
Merge branch 'feature/storage-stg74' into get-file-ranges-feature
xiafu-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type needs to be changed, it's not a tuple now,
I'm thinking if we want to create a new API to get range diff, sharing the same API with get_ranges could cause confusion I feel.
Since
# type: (...) -> Union[List[Dict[str, int]], Tuple[List[Dict[str, int]], List[Dict[str, int]]]]
is kinda confusing. Users might not sure if they will get a Tuple or List.@annatisch @kasobol-msft Do you have any opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiafu-msft - yes we shouldn't have mixed return types.
So are "cleared ranges" only available when the diff snapshot parameter is provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct @annatisch