Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] mode (ReceiveMode) parameter needs better exception behavior #13531

Merged
merged 5 commits into from
Sep 21, 2020
Merged

[ServiceBus] mode (ReceiveMode) parameter needs better exception behavior #13531

merged 5 commits into from
Sep 21, 2020

Commits on Sep 2, 2020

  1. mode parameter needs better exception behavior, as if it is mis-typed… 

    … now it will return an AttributeError further down the stack without useful guidance (and only does so when creating the handler, as well)

Will now return a TypeError at initialization.
    @KieranBrantnerMagee
    KieranBrantnerMagee committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    0ee28be View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Merge from upstream master

    @KieranBrantnerMagee
    KieranBrantnerMagee committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    7df95cb View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. merge from upstream master

    @KieranBrantnerMagee
    KieranBrantnerMagee committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    50d00cf View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Fix mode->receive_mode change missed in merge (within test)

    @KieranBrantnerMagee
    KieranBrantnerMagee committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    2eb7d63 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Update CHANGELOG.md 

    Add note of AttributeError->TypeError behavior for receive_mode misalignment to changelog.
    @KieranBrantnerMagee
    KieranBrantnerMagee authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    fc246ea View commit details
    Browse the repository at this point in the history