Clean-up excess includes for triggers. #13970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Azure.Identity
Event Hubs
Storage
mitchdenny
added
EngSys
|
/check-enforcer override |
|
/check-enforcer evaluate |
|
/check-enforcer reset |
|
@scbedd did you reach a conclusion when you brought this up with the Python team? |
|
Closing this for now. We can come back to it if there is a desire to reduce the scope of what triggers. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
May 6, 2021
StoragePool RP New Preview API (Azure#13970) * No changes -- new version directory with old specs * New API version Changes * Validation errors * revisions * Fixes * Revisions * Revisions * Revisions * Updates * Annotating required property * Availability zone is not required during Disk Pool Creation * Fixing swagger route typo * Fixes Avocado errors due to swagger file not being referenced * Updated python readme * [python] Update readme.md (Azure#14184) * Update readme.md * Update readme.python.md * Fix merge conflicts * Swagger linting errors Co-authored-by: Harshitha Akkaraju <hakkaraj@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more for discussion than anything else at this point. I was helping out the management plane team with a new pipeline an observed that the
ci.ymlfile they were using had some extra path filters fortools/,sdk/core/, andeng/. It wasn't for all service directories and it got me thinking if it was intentional or not.Do we still need these triggers, especially on
eng/. When sync PRs are pushed this has the potential to really hammer the build pools with this broader coverage created by the triggers.