[Fileshare] Added support for set share properties including access tier #14355
Conversation
tasherif-msft
added
the
feature-request
tasherif-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
rakshith91,
xiafu-msft and
zezha-msft
as code owners
ghost
added
the
tasherif-msft
changed the title
|
/azp run python - storage - ci |
|
No pipelines are associated with this pull request. |
|
/azp run python - storage - ci |
|
/azp where |
|
Azure DevOps orgs getting events for this repository: |
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tasherif-msft
force-pushed
the
set-share-lease
branch
from
cd6b6ff
to
5598b19
Compare
tasherif-msft
changed the title
tasherif-msft
changed the title
|
|
||
| .. versionadded:: 12.6.0 | ||
|
|
||
| :param options: |
There was a problem hiding this comment.
We don't need to worry about overload for python, so I think we can list the options as keyword arguments. What do you think @annatisch @kasobol-msft
There was a problem hiding this comment.
IMO sounds good. But I'd defer this to python experts.
| @@ -350,6 +369,7 @@ def _from_generated(cls, generated): | |||
| props.last_modified = generated.properties.last_modified | |||
| props.etag = generated.properties.etag | |||
| props.quota = generated.properties.quota | |||
| props.access_tier = generated.properties.access_tier | |||
There was a problem hiding this comment.
In blob we call it blob_tier, do we want to be consistent and call it's share_tier?
There was a problem hiding this comment.
I actually think access_tier is more concise. Since this is now a property of shares we shouldn't have a prefix share. For example, we call the property quota not share_quota or etag not share_etag. I believe for future naming access_tier is the better naming convention.
There was a problem hiding this comment.
it's should be blob_access_tier and share_access_tier or access_tier. I know we have convention to prefix things with blob_/share_ somewhere (not sure if this applies here). But we should also make sure that "access_tier" can be easily matched with other SDKs and REST docs.
There was a problem hiding this comment.
Looking at https://github.com/Azure/azure-sdk-for-java/pull/15897/files, it appears access_tier would be consistent with other SDKs
There was a problem hiding this comment.
Yeah - I think access_tier is a good name. No need for share prefix as it's already on ShareProeprties.
If we wanted, what we can do in a future Blobs release is to add access_tier and stop documenting blob_tier - it will always still be there of course so it will never be a breaking change.
…into add_business_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits) samples updates from other branch (Azure#14598) [form recognizer] add multipage business card form (Azure#14613) Remove extra newline at the end of the file (Azure#14608) Update .gitignore (Azure#14609) Enable the link check for link verification step. (Azure#14604) Switch the content from array to string. (Azure#14576) [Fileshare] Added support for set share properties including access tier (Azure#14355) [EventHubs & ServiceBus] add python3.9 support (Azure#14301) Add parse_key_vault_certificate_id method and tests (Azure#14518) Enable Codespaces. (Azure#14564) Failed the anchor links with Uppercase. (Azure#14535) Sync eng/common directory with azure-sdk-tools for PR 1091 (Azure#14550) Only check the touched markdown files in PR for the Verify link step (Azure#14466) [formrecognizer] add logic to set page_number on `ContactNames` field (Azure#14552) update deps for multiapi (Azure#14534) add sample tests for business cards and model compose (Azure#14515) Ma accept str for datetime (Azure#14517) Fix anchor links so they work when converting to html [formrecognizer] initial selection marks (Azure#14024) Mypy Compatibilty for EventGrid (Azure#14344) ...
No description provided.