Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OpenTelemetry exporter code #14784

Merged
merged 30 commits into from
Nov 11, 2020

Conversation

hectorhdzg
Copy link
Member

Moving exporter code from https://github.com/microsoft/opentelemetry-azure-monitor-python
Updated code to use swagger generated data models and ApplicationInsights client
Adding tests and examples

@rakshith91
Copy link
Contributor

Please rename the examples/ folder to samples/

@rakshith91
Copy link
Contributor

/azp run python - monitor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor

/azp run python - monitor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor

/azp run python - monitor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor

/azp run python - monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -1,17 +1,18 @@
# Release History

## Unreleased
## 1.0.0b1 (Unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we changing the version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this also doesn't follow semver? (open-telemetry/opentelemetry-python#1222 (comment))

Copy link
Contributor

@rakshith91 rakshith91 Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would release this package eventually as the first preview of the major version.

I've just updated it with the language precedent set. the python way to say 1.0.0-beta (a semantic guideline of semver) would be 1.0.0b1 (syntactic to python)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, we currently adhere to semvers for all the GAed libraries- and for pre releases, we are compatible with pep 440 , https://www.python.org/dev/peps/pep-0440/#id27

@rakshith91
Copy link
Contributor

/azp run python - monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

rakshith91
rakshith91 previously approved these changes Nov 6, 2020
lzchen
lzchen previously approved these changes Nov 9, 2020
@hectorhdzg hectorhdzg dismissed stale reviews from lzchen and rakshith91 via de56d02 November 10, 2020 19:33
@hectorhdzg hectorhdzg merged commit 27e6131 into Azure:master Nov 11, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Nov 14, 2020
…into new_polling

* 'master' of https://github.com/Azure/azure-sdk-for-python: (281 commits)
  [Communication] Add variable groups necessary for using new azure subscription (Azure#15213)
  Sync eng/common directory with azure-sdk-tools for PR 1153 (Azure#15322)
  [Communication] Update version for Preview 3 release (Azure#15317)
  Increment package version after release of azure_data_tables (Azure#15291)
  [monitor] README + samples _ ci.yml (Azure#15288)
  refdoc aka.ms link was broken and silently redirecting, have replaced with azuresdkdocs link as is used in other SDKs. (Azure#15169)
  Sync eng/common directory with azure-sdk-tools for PR 1202 (Azure#15297)
  Updating OT exporter to consume latest version of OpenTelemetry API/SDK (Azure#15289)
  Change live test resource DeleteAfterHours tag to 8 hours (Azure#15294)
  Add Invoke-DevOpsAPI.ps1, Add functions for Canceling and Listing Builds (Azure#15013)
  The original one is removed. Point to the new one (Azure#15287)
  Sync eng/common directory with azure-sdk-tools for PR 1170 (Azure#15087)
  Adding OpenTelemetry exporter code (Azure#14784)
  update external link (Azure#15273)
  Remove invalid characters in basename sourced from username (Azure#15268)
  Sync eng/common directory with azure-sdk-tools for PR 1188 (Azure#15267)
  Increment version for core releases (Azure#15269)
  Increment package version after release of azure_identity (Azure#15266)
  Fix CI (Azure#15265)
  Increment package version after release of azure_eventgrid (Azure#15262)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants