Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aiodns from our CI #15424

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Remove aiodns from our CI #15424

merged 2 commits into from
Nov 18, 2020

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Nov 18, 2020

aiodns is an optional dependency to make DNS resolution faster for aiohttp. That itself should enough to not install it on CI, but on top of that, it depends on "pycares" that is not available on Python 3.9 as wheels, and makes Windows installation complex. this creates situations where contributors can't setup a dev venv on 3.9 Windows, for a package that is not necessary for dev in the first place.
So killing it.

@lmazuel lmazuel requested review from xiangyan99 and scbedd November 18, 2020 16:57
@ghost ghost added the Azure.Core label Nov 18, 2020
xiangyan99
xiangyan99 previously approved these changes Nov 18, 2020
@lmazuel lmazuel merged commit c3102f7 into master Nov 18, 2020
@lmazuel lmazuel deleted the remove_aiodns branch November 18, 2020 21:36
iscai-msft added a commit that referenced this pull request Nov 19, 2020
…into feature/textanalytics5.2

* 'master' of https://github.com/Azure/azure-sdk-for-python: (40 commits)
  Sync eng/common directory with azure-sdk-tools for PR 1203 (#15441)
  [ServiceBus] Graceful noops for methods taking empty lists. (#15286)
  [text analytics] add sample stories and improve documents (#15429)
  [ServiceBus] Enable FQDNs and connection strings to support newlines and protocol prefixing (e.g. sb://) (#15212)
  Fix combined session+auto-auto_lock_renewer+receive-and-delete mode issue where registry would fail during receipt.  Add tests and changelog entry. (#15343)
  Add Update-python-CIConfig (#15379)
  Remove aiodns from our CI (#15424)
  Resolve Broken Portal Link (#15431)
  [Key Vault] Update tests which disable soft-delete (#15352)
  switching order on readme (#15426)
  [text analtyics] add abby as codeowner (#15376)
  test (#15402)
  fix iothub version (#15405)
  [T2] Batch (#14757)
  [T2] Policyinsights (#14794)
  [T2] apimanagement Wave3 (#14804)
  [T2] devtestlabs Wave3 (#14795)
  [T2]eventgrid wave3 (#14805)
  [T2] Search (#14823)
  test,version,CHANGELOG (#14838)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jul 30, 2021
[Batch] Make readme.md and swagger titles consistent (Azure#15424)

* [Batch] Changed "title" from BatchManagement to BatchManagementClient

Autorest is using this to generate the name of the client class. Changing this will avoid a breaking change in the Java SDK that is about to be released.

* Make readme.md titles consistent with swagger
msyyc added a commit that referenced this pull request Jul 30, 2021
* CodeGen from PR 15424 in Azure/azure-rest-api-specs
[Batch] Make readme.md and swagger titles consistent (#15424)

* [Batch] Changed "title" from BatchManagement to BatchManagementClient

Autorest is using this to generate the name of the client class. Changing this will avoid a breaking change in the Java SDK that is about to be released.

* Make readme.md titles consistent with swagger

* version,CHANGELOG

* test

* test

* Update shared_requirements.txt

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants