Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.9 to live test matrix #15488

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

kristapratico
Copy link
Member

No description provided.

OSVmImage: 'ubuntu-18.04'
PythonVersion: '3.8'
PythonVersion: '3.9.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it matters but is there a reason this is 3.9.0 instead of 3.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm not sure. I copied this from the servicebus tests.yml. Will wait on final say from @scbedd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is fine. I will check if py39 has been added to the actual images themselves. We would use 3.9 like you're asking if it is already on the machine Wes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this would need to be changed in 3 or so locations. This should probably just merge.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks reasonable to me assuming we are good with removing the 38 testing and replace it with 3.9.

@kristapratico kristapratico merged commit 0bf4ea9 into Azure:master Nov 20, 2020
@kristapratico kristapratico deleted the live-test-39 branch November 20, 2020 23:57
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Aug 3, 2021
Update web readme and readme.python (Azure#15488)

* Update web readme and readme.python

* Update readme
msyyc pushed a commit that referenced this pull request Aug 19, 2021
* CodeGen from PR 15488 in Azure/azure-rest-api-specs
Update web readme and readme.python (#15488)

* Update web readme and readme.python

* Update readme

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
iscai-msft pushed a commit that referenced this pull request Sep 29, 2021
* CodeGen from PR 15488 in Azure/azure-rest-api-specs
Update web readme and readme.python (#15488)

* Update web readme and readme.python

* Update readme

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants