Run smoke tests against latest published versions in release pipeline #15865
Conversation
benbp
requested review from
annatisch,
chlowell,
danieljurek,
lmazuel,
mitchdenny,
rakshith91,
scbedd,
shurd,
southpolesteve and
weshaggard
as code owners
benbp
added
the
Central-EngSys
benbp
force-pushed
the
benbp/smoke-test-on-release
branch
from
90e7211 to
7b534aa
Compare
There was a problem hiding this comment.
I don't see any issues with this. The template looks mostly the same except for the two conditional injections.
I'd like to see a successful run of the template w/ these new changes, just to confirm we're not missing any requirements gotchas in the release stages.
|
@scbedd here's a run of the normal smoke tests pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=660094&view=results Here's a run of just the smoke test portion of the release pipeline (with actual build/release steps commented out): https://dev.azure.com/azure-sdk/internal/_build/results?buildId=660110&view=results If you can think of a way to exercise the whole release pipeline in a non-consequential way, I'd love to do that too. |
|
@benbp Dozie has some excellent automation in place to execute a release of the template package (including all stages) with a version tagged by buildNumber. That's one way we can actually exercise it. |
|
You're good to just merge this IMO though. That test you did with the actual stuff commented out works for me as well. |
|
@scbedd awesome, I'll follow up with @chidozieononiwu to get that tested! Since I'm out for the next two weeks, I'm going to wait to merge this PR until I'm back, just in case it breaks anything (I don't anticipate anyone needing these changes until then anyway). |
|
@weshaggard I updated this PR to pull in versions from the build artifacts, similar to the net and js PRs. |
benbp
force-pushed
the
benbp/smoke-test-on-release
branch
from
b96ae1c to
4246c90
Compare
benbp
force-pushed
the
benbp/smoke-test-on-release
branch
from
4246c90 to
698ff6c
Compare
…Azure#15865) * Run smoke tests on release * Use pipeline artifact versions for smoke test on release * Use correct logic for daily conditional
This PR updates the package release pipelines to run smoke tests against the latest published versions (GA and/or beta) after the release stage in the release pipeline. This only applies for packages that are included as dependencies in the smoke tests (keyvault, storage, eventhub).
Azure/azure-sdk#1999