removing create_configuration and using generated code instead #15908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
reviewed
Dec 22, 2020
| @@ -231,7 +232,15 @@ def _create_pipeline(self, credential, **kwargs): | |||
| elif credential is not None: | |||
| raise TypeError("Unsupported credential: {}".format(credential)) | |||
|
|
|||
| config = kwargs.get("_configuration") or create_configuration(**kwargs) | |||
| config = kwargs.get("_configuration") or AzureTableConfiguration( | |||
There was a problem hiding this comment.
I didn't see this whole code to create a pipeline, you don't really need to do that anymore
I would actually suggest taking a look at kv: https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py#L46. We used to have this same code, where we would list all the policies, etc, but we changed it to this. Should get rid of. all of this creating a pipeline / transport / config before calling into thegeneratedclient
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12743