Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed syntax error in EH async auth sample #15955

Merged
merged 1 commit into from
Jan 4, 2021
Merged

fixed syntax error in EH async auth sample #15955

merged 1 commit into from
Jan 4, 2021

Conversation

swathipil
Copy link
Member

addressing: #15114

  • connection_string_authentication_async.py

line 23: results in "SyntaxError: 'async with' outside async function"

@ghost ghost added the Event Hubs label Dec 30, 2020
@swathipil swathipil mentioned this pull request Dec 30, 2020
Closed
rakshith91
rakshith91 approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@rakshith91 rakshith91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yunhaoling
yunhaoling approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swathipil swathipil merged commit fb10a33 into Azure:master Jan 4, 2021
@swathipil swathipil deleted the eh-auth-sample branch January 5, 2021 02:21
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jan 8, 2021
@swathipil @rakshith91
fixed 'async with outside async func' syntax error in EH async auth w…
a3dd1aa 
…ith conn str sample (Azure#15955)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jan 8, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
184e235 
…into new_polling

* 'master' of https://github.com/Azure/azure-sdk-for-python: (85 commits)
  Update to Update-Changelog.ps1 (Azure#15981)
  Fix put_encrypted_blob function (Azure#15918)
  renamed checkpoint by batch samples to by event count (Azure#15977)
  Migration guide for EventGrid (Azure#15731)
  Clearer message for incomplete environment configuration (Azure#15974)
  renamed async checkpoint sample readme title (Azure#15958)
  fixed 'async with outside async func' syntax error in EH async auth with conn str sample (Azure#15955)
  fixed typo in EH sample + readme (Azure#15954)
  Clean up batch delete sample (Azure#15898)
  Add azure core to mgmt dependency (Azure#15969)
  [T2] GA rdbms (Azure#15934)
  GA commerce track2 sdk (Azure#15907)
  GA batch track2 sdk (Azure#15906)
  GA policyinsights track2 sdk (Azure#15905)
  GA search track2 sdk (Azure#15904)
  GA notificationhubs track2 sdk (Azure#15903)
  [T2] GA relay (Azure#15902)
  GA cognitiveservices track2 sdk (Azure#15901)
  GA advisor track2 sdk (Azure#15900)
  GA marketplaceordering track2 sdk (Azure#15899)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakshith91 rakshith91 rakshith91 approved these changes

@yunhaoling yunhaoling yunhaoling approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@KieranBrantnerMagee KieranBrantnerMagee Awaiting requested review from KieranBrantnerMagee

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swathipil @rakshith91 @yunhaoling