OT Exporter retry when there are network issues

sdk/monitor/azure-opentelemetry-exporter-azuremonitor/CHANGELOG.md

@@ -2,18 +2,21 @@
 
 ## 1.0.0b2 (Unreleased)
 
+- Fix to only retry upon request error
+  ([#15344](https://github.com/Azure/azure-sdk-for-python/pull/15344))
+
   **Breaking Changes**
   - Rename Azure Trace exporter class, only allow connection string configuration
     ([#15349](https://github.com/Azure/azure-sdk-for-python/pull/15349))
 
-- OpenTelemetry Exporter use Resources API to retrieve cloud role props
-  ([#15816](https://github.com/Azure/azure-sdk-for-python/pull/15816))
+  - OpenTelemetry Exporter use Resources API to retrieve cloud role props
+    ([#15816](https://github.com/Azure/azure-sdk-for-python/pull/15816))
 
-- Change span to envelope conversion to adhere to common schema and other languages
-  ([#15344](https://github.com/Azure/azure-sdk-for-python/pull/15344))
+  - Change span to envelope conversion to adhere to common schema and other languages
+    ([#15344](https://github.com/Azure/azure-sdk-for-python/pull/15344))
 
-- This library is renamed to `azure-opentelemetry-exporter-azuremonitor`.
-  ([#15344](https://github.com/Azure/azure-sdk-for-python/pull/15344))
+  - This library is renamed to `azure-opentelemetry-exporter-azuremonitor`.
+    ([#16030](https://github.com/Azure/azure-sdk-for-python/pull/16030))
 
 ## 1.0.0b1 (2020-11-13)
 

sdk/monitor/azure-opentelemetry-exporter-azuremonitor/azure/opentelemetry/exporter/azuremonitor/export/_base.py

@@ -8,7 +8,7 @@
 
 from opentelemetry.sdk.trace.export import SpanExportResult
 
-from azure.core.exceptions import HttpResponseError
+from azure.core.exceptions import HttpResponseError, ServiceRequestError
 from azure.core.pipeline.policies import ContentDecodePolicy, HttpLoggingPolicy, RequestIdPolicy
 from azure.opentelemetry.exporter.azuremonitor._generated import AzureMonitorClient
 from azure.opentelemetry.exporter.azuremonitor._generated._configuration import AzureMonitorClientConfiguration
@@ -132,12 +132,18 @@ def _transmit(self, envelopes: typing.List[TelemetryItem]) -> ExportResult:
                 if is_retryable_code(response_error.status_code):
                     return ExportResult.FAILED_RETRYABLE
                 return ExportResult.FAILED_NOT_RETRYABLE
-            except Exception as ex:
+            except ServiceRequestError as request_error:
+                # Errors when we're fairly sure that the server did not receive the
+                # request, so it should be safe to retry.
                 logger.warning(
-                    "Retrying due to transient client side error %s.", ex
+                    "Retrying due to server request error: %s.", request_error
                 )
-                # client side error (retryable)
                 return ExportResult.FAILED_RETRYABLE
+            except Exception as ex:
+                logger.error(
+                    "Envelopes could not be exported and are not retriable: %s.", ex
+                )
+                return ExportResult.FAILED_NOT_RETRYABLE
             return ExportResult.FAILED_NOT_RETRYABLE
         # No spans to export
         return ExportResult.SUCCESS
@@ -148,12 +154,13 @@ def is_retryable_code(response_code: int) -> bool:
     Determine if response is retryable
     """
     return bool(response_code in (
-        206,  # Retriable
+        206,  # Partial success
         408,  # Timeout
         429,  # Throttle, too Many Requests
         439,  # Quota, too Many Requests over extended time
         500,  # Internal Server Error
         503,  # Service Unavailable
+        504,  # Gateway timeout
     ))