[Communication] Use CommunicationRefreshOptions in CommunicaitonTokenCredential #16228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sacheu
requested review from
ankitarorabit,
memontic-ms,
RezaJooyandeh,
turalf and
a team
as code owners
ghost
added
the
….com/Azure/azure-sdk-for-python into sacheu/communication_refresh_options
jbeauregardb
approved these changes
Jan 19, 2021
turalf
approved these changes
Jan 20, 2021
| :raises: TypeError | ||
| """ | ||
|
|
||
| def __init__(self, # type: str |
There was a problem hiding this comment.
nit: type comment seems to be misplaced?
| :raises: TypeError | ||
| """ | ||
|
|
||
| def __init__(self, # type: str |
There was a problem hiding this comment.
nit: here too, the type comment should be below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python implementation of https://github.com/Azure/azure-sdk-for-java/pull/18060/files in Java repo