Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin azure-keyvault-administration dev requirement #16260

Merged
1 commit merged into from
Jan 20, 2021
Merged

Conversation

chlowell
Copy link
Member

azure-keyvault-administration fails the mindependency test because its dev_requirements.txt includes the master branch's azure-storage-blob, which requires a later version of azure-core. Azure-keyvault-administration doesn't need the latest blob API, so a simple fix is to pin an azure-storage-blob version having a compatible azure-core requirement.

@ghost
Copy link

ghost commented Jan 20, 2021

Hello @chlowell!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@chlowell
Copy link
Member Author

/check-enforcer override

@ghost ghost merged commit cd446b4 into master Jan 20, 2021
@ghost ghost deleted the chlowell/fix-dev-reqs branch January 20, 2021 23:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants