Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data as positional for cloud event #16288

Merged
merged 7 commits into from
Jan 21, 2021
Merged

Add data as positional for cloud event #16288

merged 7 commits into from
Jan 21, 2021

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Jan 21, 2021 •
edited
Loading

Fixes #16289

@ghost ghost added the Event Grid label Jan 21, 2021
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91 rakshith91 marked this pull request as ready for review January 21, 2021 20:27
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling
yunhaoling reviewed Jan 21, 2021
View reviewed changes
sdk/eventgrid/azure-eventgrid/azure/eventgrid/_models.py Outdated
Comment on lines 172 to 173
:keyword data_version: The schema version of the data object. If not provided, will be stamped with an empty value.
:type data_version: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also Optional in the description and type?

Rakshith Bhyravabhotla and others added 2 commits January 21, 2021 13:44
@yunhaoling
Apply suggestions from code review
b630727 
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
@rakshith91
docs
ce91f78
@rakshith91 rakshith91 enabled auto-merge (squash) January 21, 2021 22:04
@yunhaoling
Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/_models.py
e08370e 
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
@rakshith91 rakshith91 merged commit 5483b6a into Azure:master Jan 21, 2021
@rakshith91 rakshith91 deleted the egfbmore branch January 21, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@swathipil swathipil Awaiting requested review from swathipil

Assignees
No one assigned
Labels
Event Grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data should be required in CloudEvent
2 participants
@rakshith91 @yunhaoling