-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communication] - Extract Identity Package out of Administration Package #16300
Conversation
initial commit: new folder for identity
…onal Added root files to identity package
Bertong extract identity
Bertong extract identity
…sonal Added tests to identity package
…dk-for-python into bertong-extract-identity
Bertong extract identity
…sonal Removed identity tests from admin package
Bertong extract identity
…sonal Removed user credential test in admin package
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
/azp run python - communication - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Update chat to reference new identity package
…sonal Updated identity test recordings
…sonal Added examples to identity README.md
@@ -3,6 +3,7 @@ | |||
## 1.0.0b4 (Unreleased) | |||
|
|||
### Breaking Changes | |||
- CommunicationIdentityClient is moved to a new package: "azure.communication.identity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need this package to be added to the ci.yml file for letting this run in the pipeline too. But it make sense to have another PR for this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the identity package to the ci.yml file.
…sonal Added identity package to ci file
No description provided.