Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Small fixes to storage-blob #17055

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[Perf] Small fixes to storage-blob #17055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/tests/perfstress_tests/_test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def add_arguments(parser):
parser.add_argument('--max-put-size', nargs='?', type=int, help='Maximum size of data uploading in single HTTP PUT. Defaults to 64*1024*1024', default=64*1024*1024)
parser.add_argument('--max-block-size', nargs='?', type=int, help='Maximum size of data in a block within a blob. Defaults to 4*1024*1024', default=4*1024*1024)
parser.add_argument('--buffer-threshold', nargs='?', type=int, help='Minimum block size to prevent full block buffering. Defaults to 4*1024*1024+1', default=4*1024*1024+1)
parser.add_argument('-c', '--max-concurrency', nargs='?', type=int, help='Maximum number of concurrent threads used for data transfer. Defaults to 1', default=1)
parser.add_argument('--max-concurrency', nargs='?', type=int, help='Maximum number of concurrent threads used for data transfer. Defaults to 1', default=1)
parser.add_argument('-s', '--size', nargs='?', type=int, help='Size of data to transfer. Default is 10240.', default=10240)
parser.add_argument('--no-client-share', action='store_true', help='Create one ServiceClient per test instance. Default is to share a single ServiceClient.', default=False)

Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-blob/tests/perfstress_tests/list_blobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class ListBlobsTest(_ContainerTest):

async def global_setup(self):
await super().global_setup()
pending = (asyncio.ensure_future(self.async_container_client.upload_blob("listtest" + str(i), data=b"")) for i in range(self.args.num_blobs))
pending = (asyncio.ensure_future(self.async_container_client.upload_blob("listtest" + str(i), data=b"")) for i in range(self.args.count))
running = list(itertools.islice(pending, 16))
while True:
# Wait for some upload to finish before adding a new one
Expand All @@ -36,4 +36,4 @@ async def run_async(self):
@staticmethod
def add_arguments(parser):
super(ListBlobsTest, ListBlobsTest).add_arguments(parser)
parser.add_argument('--num-blobs', nargs='?', type=int, help='Number of blobs to list. Defaults to 100', default=100)
parser.add_argument('-c', '--count', nargs='?', type=int, help='Number of blobs to list. Defaults to 100', default=100)
8 changes: 0 additions & 8 deletions sdk/storage/azure-storage-blob/tests/perfstress_tests/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,9 @@
class UploadTest(_BlobTest):
def __init__(self, arguments):
super().__init__(arguments)
blob_name = "downloadtest"
self.blob_client = self.container_client.get_blob_client(blob_name)
self.async_blob_client = self.async_container_client.get_blob_client(blob_name)
self.upload_stream = RandomStream(self.args.size)
self.upload_stream_async = AsyncRandomStream(self.args.size)

async def global_setup(self):
await super().global_setup()
data = get_random_bytes(self.args.size)
await self.async_blob_client.upload_blob(data)

def run_sync(self):
self.upload_stream.reset()
self.blob_client.upload_blob(
Expand Down