[Container Registry] Acr delete tag #17608

seankane-msft · 2021-03-26T21:55:07Z

No description provided.

…there

check-enforcer · 2021-04-01T17:42:32Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

iscai-msft · 2021-04-01T23:57:57Z

...ry/azure-containerregistry/azure/containerregistry/aio/_async_container_repository_client.py

@@ -63,15 +62,15 @@ def delete_registry_artifact(self, digest: str, **kwargs) -> None:
        """
        raise NotImplementedError("Has not been implemented")

-    def delete_tag(self, tag: str, **kwargs) -> None:
+    async def delete_tag(self, tag: str, **kwargs) -> None:


nit: "Delete a tag from a repository"

sdk/containerregistry/azure-containerregistry/tests/test_container_registry_client_async.py

kristapratico

🚀

kristapratico · 2021-04-02T00:03:32Z

...s/recordings/test_container_registry_client_async.test_delete_repository_does_not_exist.yaml

+    status:
+      code: 200
+      message: OK
+    url: https://seankane.azurecr.io/oauth2/exchange


maybe open an issue to scrub this?

sdk/containerregistry/azure-containerregistry/tests/test_container_registry_client_async.py

seankane-msft · 2021-04-02T12:49:34Z

/check-enforcer evaluate

seankane-msft · 2021-04-02T15:03:52Z

/check-enforcer evaluate

seankane-msft · 2021-04-02T15:45:25Z

/azp run prepare-pipelines

azure-pipelines · 2021-04-02T15:45:34Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2021-04-02T16:05:02Z

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

seankane-msft · 2021-04-02T16:05:48Z

/check-enforcer override

seankane-msft added 30 commits February 22, 2021 14:43

generated code from swagger

5e854e6

adding files from template

eb5eb54

adding a tests.yml file

785564d

outlining base structures

561128f

adding more skeleton code

beba7fc

formatting code

9c7acd5

adding some async files

8c03d93

fixes for apiview

5a16d1c

added models and clients based on feedback from arch board

b628b6f

running black to keep code clean

b70ce96

more changes to auth

2bedabe

have a basic pipeline

fa6f78e

added an auth policy for username & password

514d03b

have a working auth policy

4063d4d

need to add a page iterator class for returned repositories

c280520

working list tags and list repositories methods

4a9cc33

adding a change to the tests.yml file to run in live mode once I get …

5e2270c

…there

added more methods

b2ba50f

adding test infra

fb4189f

adding swagger file

7108594

regen with Jeremys swagger, fixing up implementations

4dd3c8c

added delete method, more models are filled out

4533cce

code formatting and adding helper method to repository client

2b3bb91

adding changes from newest swagger

34b094e

updated generated code

a4d0258

adding tests for list and delete not exists, small changes to tests.yml

2058b4a

adding more list tests

70d8524

updating readme and setup

9da7eee

adding more things the pipelines need

eea6749

fixing pylint issues to get pipeline green

875b422

seankane-msft requested review from scbedd and weshaggard as code owners March 26, 2021 21:55

seankane-msft added 5 commits March 29, 2021 10:51

cleanup

c26d422

forgot to include a recording

96d9095

fixing up recording files

8f710ae

merge conflicts

3ffa843

linting issues and running black

d307988

seankane-msft requested review from iscai-msft, kristapratico, xiangyan99, rakshith91, mccoyp and swathipil April 1, 2021 17:37

iscai-msft approved these changes Apr 1, 2021

View reviewed changes

kristapratico approved these changes Apr 2, 2021

View reviewed changes

seankane-msft mentioned this pull request Apr 2, 2021

[Container Registry] Scrub URL from requests #17760

Closed

seankane-msft added 3 commits April 2, 2021 08:58

delete on registry client test

183a869

small changes to test files, adding test for delete_repository

a7d2082

docstring fix

b95eeb8

ci file fix

4f3e52f

seankane-msft added the auto-merge label Apr 2, 2021

ghost merged commit 808f66e into Azure:master Apr 2, 2021

seankane-msft deleted the acr-delete-tag branch April 2, 2021 16:06

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Container Registry] Acr delete tag #17608

[Container Registry] Acr delete tag #17608

seankane-msft commented Mar 26, 2021

check-enforcer bot commented Apr 1, 2021

iscai-msft Apr 1, 2021

kristapratico left a comment

kristapratico Apr 2, 2021

seankane-msft commented Apr 2, 2021

seankane-msft commented Apr 2, 2021

seankane-msft commented Apr 2, 2021

azure-pipelines bot commented Apr 2, 2021

ghost commented Apr 2, 2021

seankane-msft commented Apr 2, 2021

[Container Registry] Acr delete tag #17608

[Container Registry] Acr delete tag #17608

Conversation

seankane-msft commented Mar 26, 2021

check-enforcer bot commented Apr 1, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

iscai-msft Apr 1, 2021

Choose a reason for hiding this comment

kristapratico left a comment

Choose a reason for hiding this comment

kristapratico Apr 2, 2021

Choose a reason for hiding this comment

seankane-msft commented Apr 2, 2021

seankane-msft commented Apr 2, 2021

seankane-msft commented Apr 2, 2021

azure-pipelines bot commented Apr 2, 2021

ghost commented Apr 2, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

seankane-msft commented Apr 2, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.