[Container Registry] Acr delete artifact #17645

seankane-msft · 2021-03-29T18:54:12Z

No description provided.

…there

swathipil

left some comments about things you probably already know :)

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_authentication_policy.py

...inerregistry/azure-containerregistry/azure/containerregistry/_container_repository_client.py

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_exchange_client.py

swathipil · 2021-03-30T21:00:52Z

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_models.py

        self.created_on = kwargs.get("created_on", None)
        self.digest = kwargs.get("digest", None)
        self.last_updated_on = kwargs.get("last_updated_on", None)
-        self.manifest_properties = kwargs.get("manifest_properties", None)
        self.operating_system = kwargs.get("operating_system", None)
+        self.references = kwargs.get("references", None)
        self.size = kwargs.get("size", None)
        self.tags = kwargs.get("tags", None)
+        self.content_permissions = kwargs.get("content_permissions", None)


I believe get already defaults to None if key is not in there, so second arg None is not needed.
(not saying this needs to be changed or anything)

swathipil · 2021-03-30T21:06:05Z

...inerregistry/azure-containerregistry/azure/containerregistry/_container_repository_client.py

+            cls=lambda objs: [
+                RegistryArtifactProperties._from_generated(x) for x in objs  # pylint: disable=protected-access
+            ],
+        )

    def list_tags(self, **kwargs):


params are specified in the docstring, but it looks like they should be keyword?

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_models.py

check-enforcer · 2021-04-01T18:54:02Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

iscai-msft · 2021-04-02T00:06:28Z

...ry/azure-containerregistry/azure/containerregistry/aio/_async_container_repository_client.py

@@ -127,7 +127,7 @@ async def list_registry_artifacts(self, **kwargs) -> AsyncItemPaged[RegistryArti
        last = kwargs.pop("last", None)
        n = kwargs.pop("page_size", None)
        orderby = kwargs.pop("order_by", None)
-        return await self._client.container_registry_repository.get_manifests(
+        return self._client.container_registry_repository.get_manifests(


why is the await gone

The list methods don't return a coroutine, they return an AsyncItemPaged

oh yeah lmao, ignore me

We can remove the "async" before the def list_registry_artifacts too

iscai-msft · 2021-04-02T00:07:50Z

sdk/containerregistry/azure-containerregistry/tests/test_container_registry_client.py

@@ -19,12 +19,14 @@
 from azure.identity import DefaultAzureCredential

 from testcase import ContainerRegistryTestClass
+from constants import TO_BE_DELETED


is this constant somethign you want exposed to users? I'm assuming not (which is how it currently is), but just double checking

No it is not, it's just so I have a consistent registry imported. I kept misspelling it and eventually made it a constant.

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_models.py

kristapratico · 2021-04-02T00:32:11Z

...ry/azure-containerregistry/azure/containerregistry/aio/_async_container_repository_client.py

@@ -127,7 +127,7 @@ async def list_registry_artifacts(self, **kwargs) -> AsyncItemPaged[RegistryArti
        last = kwargs.pop("last", None)
        n = kwargs.pop("page_size", None)
        orderby = kwargs.pop("order_by", None)
-        return await self._client.container_registry_repository.get_manifests(
+        return self._client.container_registry_repository.get_manifests(


We can remove the "async" before the def list_registry_artifacts too

...ry/azure-containerregistry/azure/containerregistry/aio/_async_container_repository_client.py

seankane-msft added 30 commits February 22, 2021 14:43

generated code from swagger

5e854e6

adding files from template

eb5eb54

adding a tests.yml file

785564d

outlining base structures

561128f

adding more skeleton code

beba7fc

formatting code

9c7acd5

adding some async files

8c03d93

fixes for apiview

5a16d1c

added models and clients based on feedback from arch board

b628b6f

running black to keep code clean

b70ce96

more changes to auth

2bedabe

have a basic pipeline

fa6f78e

added an auth policy for username & password

514d03b

have a working auth policy

4063d4d

need to add a page iterator class for returned repositories

c280520

working list tags and list repositories methods

4a9cc33

adding a change to the tests.yml file to run in live mode once I get …

5e2270c

…there

added more methods

b2ba50f

adding test infra

fb4189f

adding swagger file

7108594

regen with Jeremys swagger, fixing up implementations

4dd3c8c

added delete method, more models are filled out

4533cce

code formatting and adding helper method to repository client

2b3bb91

adding changes from newest swagger

34b094e

updated generated code

a4d0258

adding tests for list and delete not exists, small changes to tests.yml

2058b4a

adding more list tests

70d8524

updating readme and setup

9da7eee

adding more things the pipelines need

eea6749

fixing pylint issues to get pipeline green

875b422

seankane-msft requested review from kristapratico, mccoyp, iscai-msft and swathipil March 29, 2021 18:54

seankane-msft self-assigned this Mar 29, 2021

seankane-msft requested review from danieljurek, mitchdenny, scbedd and weshaggard as code owners March 29, 2021 18:54

seankane-msft added 2 commits March 30, 2021 08:36

fixing up recording files

7ed4a02

linting issue

850d699

swathipil reviewed Mar 30, 2021

View reviewed changes

seankane-msft added 3 commits April 1, 2021 14:44

merge conflicts

86c0b5b

run black

8ad7702

undoing all changes to generated code

e228e3b

seankane-msft requested review from swathipil, rakshith91 and xiangyan99 and removed request for weshaggard, scbedd, danieljurek and mitchdenny April 1, 2021 18:48

iscai-msft approved these changes Apr 2, 2021

View reviewed changes

seankane-msft changed the title ~~[Do Not Merge][Container Registry] Acr delete artifact~~ [Container Registry] Acr delete artifact Apr 2, 2021

kristapratico reviewed Apr 2, 2021

View reviewed changes

seankane-msft added 2 commits April 2, 2021 13:04

merge conflicts

5cb3d0f

adding distributed trace decorators

738eb9e

seankane-msft merged commit 5c4d08b into Azure:master Apr 2, 2021

seankane-msft deleted the acr-delete-artifact branch April 2, 2021 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Container Registry] Acr delete artifact #17645

[Container Registry] Acr delete artifact #17645

seankane-msft commented Mar 29, 2021

swathipil left a comment •

edited

Loading

swathipil Mar 30, 2021

swathipil Mar 30, 2021

check-enforcer bot commented Apr 1, 2021

iscai-msft Apr 2, 2021

seankane-msft Apr 2, 2021

iscai-msft Apr 2, 2021

kristapratico Apr 2, 2021

iscai-msft Apr 2, 2021

seankane-msft Apr 2, 2021

kristapratico Apr 2, 2021

[Container Registry] Acr delete artifact #17645

[Container Registry] Acr delete artifact #17645

Conversation

seankane-msft commented Mar 29, 2021

swathipil left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

check-enforcer bot commented Apr 1, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swathipil left a comment •

edited

Loading