-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Container Registry] ACR list_repositories pageable #17714
Merged
Merged
Changes from all commits
Commits
Show all changes
103 commits
Select commit
Hold shift + click to select a range
5e854e6
generated code from swagger
seankane-msft eb5eb54
adding files from template
seankane-msft 785564d
adding a tests.yml file
seankane-msft 561128f
outlining base structures
seankane-msft beba7fc
adding more skeleton code
seankane-msft 9c7acd5
formatting code
seankane-msft 8c03d93
adding some async files
seankane-msft 5a16d1c
fixes for apiview
seankane-msft b628b6f
added models and clients based on feedback from arch board
seankane-msft b70ce96
running black to keep code clean
seankane-msft 2bedabe
more changes to auth
seankane-msft fa6f78e
have a basic pipeline
seankane-msft 514d03b
added an auth policy for username & password
seankane-msft 4063d4d
have a working auth policy
seankane-msft c280520
need to add a page iterator class for returned repositories
seankane-msft 4a9cc33
working list tags and list repositories methods
seankane-msft 5e2270c
adding a change to the tests.yml file to run in live mode once I get …
seankane-msft b2ba50f
added more methods
seankane-msft fb4189f
adding test infra
seankane-msft 7108594
adding swagger file
seankane-msft 4dd3c8c
regen with Jeremys swagger, fixing up implementations
seankane-msft 4533cce
added delete method, more models are filled out
seankane-msft 2b3bb91
code formatting and adding helper method to repository client
seankane-msft 34b094e
adding changes from newest swagger
seankane-msft a4d0258
updated generated code
seankane-msft 2058b4a
adding tests for list and delete not exists, small changes to tests.yml
seankane-msft 70d8524
adding more list tests
seankane-msft 9da7eee
updating readme and setup
seankane-msft eea6749
adding more things the pipelines need
seankane-msft 875b422
fixing pylint issues to get pipeline green
seankane-msft 648102b
making all tests live tests
seankane-msft 7a6bd87
updating ci and readme with tables copies
seankane-msft f82ed35
updates to readme
seankane-msft 6ba90be
adding more changes
seankane-msft b0922ba
draft based on pallavis code
seankane-msft 82c5d3c
updating readme
seankane-msft 103db71
removing old sections from readme
seankane-msft 9a26fcf
more readme deletions
seankane-msft 8ec00fd
adding auth policy back in
seankane-msft 7e4333e
ignore swagger readme
seankane-msft 5d12869
adding devtoolsback
seankane-msft 5bd806b
readme fix, linting fix
seankane-msft b56c29e
updating shared reqs
seankane-msft 5151b8d
regenerated code, fixed changelog, modified test structure
seankane-msft cb9611b
formatting
seankane-msft cf02b85
fixed up all lint and mypy issues
seankane-msft 544c9b7
formatting
seankane-msft 1f1eb4c
adding devtools to dev_reqs
seankane-msft 643e937
including samples and license in manifest, thank you scbedd
seankane-msft dfdbe82
updating swagger
seankane-msft d68285b
Merge branch 'acr' of https://github.com/seankane-msft/azure-sdk-for-…
seankane-msft 93ad7c4
adding skeleton for auth flow
seankane-msft c1f5198
more auth files
seankane-msft 166661e
committing for izy to take a look
seankane-msft b14a81b
forgot new files
seankane-msft 06fb6a5
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
seankane-msft fc88483
working auth policy using challenge
seankane-msft da18b29
working tests
seankane-msft f3dc746
deleting recordings
seankane-msft aef65bd
authentication flow test
seankane-msft 6304e37
regenerated
seankane-msft 17a1a07
fixing up test
seankane-msft 7465c81
new generated code, fixed user agent, passing tests
seankane-msft 7ed5107
adding generated and merge conflict repairs
seankane-msft 340d128
fixing up a few tests
seankane-msft 76b8ca0
changing a test slightly
seankane-msft ac6352b
async policy almost working, problem with the same url encoding
seankane-msft ce532bc
more test fixes
seankane-msft 6be366a
working live and playback
seankane-msft d8e3a4d
linting fixes, had to remove mypy because of issues in generated
seankane-msft 5d97e0b
adding conftest, fixing up async issue
seankane-msft 451a186
renaming the async test file
seankane-msft 23caed4
fixing async tests
seankane-msft f4799e5
more fixes
seankane-msft 35df077
removing async tests folder
seankane-msft f95947d
addressing charles and anna's comments, thank you both
seankane-msft 0941cec
removing more from authpolicy
seankane-msft 4714e61
removing exchange client
seankane-msft 94c3488
fixing up scrubber
seankane-msft 822d407
addressing charles comments on auth and exchange clients
seankane-msft db97e0f
fixed up list_repositories method
seankane-msft 52a746f
merge conflicts
seankane-msft 89ab5d0
page_size -> results_per_page
seankane-msft a728852
list tags not ready for results_per_page
seankane-msft f2a5da9
fixing up sync pageables
seankane-msft 31fc9ff
running black
seankane-msft db4040f
async list manifests operations
seankane-msft 0be38fe
async list tags methods complete
seankane-msft 3e6b8c2
linting
seankane-msft 4b11a77
linting fixes
seankane-msft 47e395b
merge conflicts
seankane-msft 0cabe74
conflicts
seankane-msft c2eaab3
fix to scrubber
seankane-msft de15691
merge conflicts
seankane-msft a30712d
black and lint fixes
seankane-msft af91b4a
merge conflicts
seankane-msft c36ed08
merge conflicts
seankane-msft 9dda7f8
new recordings
seankane-msft a8adc8b
fixing setup to make verify readmes happy
seankane-msft 0fcb0b8
greater than -> greater than or equal
seankane-msft 64c8fc0
(hopefully) final changes
seankane-msft 23f55d6
lint fixes
seankane-msft 0a2c1eb
krista, mccoy, and swathis comments, thank you all
seankane-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, lot of code, sorry you had to copy that. I think the code looks reasonable, my only question is if you want to move this code to the helper section. Not a big deal, just think keeping the main container registry client page as bare as possible is neater
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that, but then I need to pass in the client too and this was a bit simpler.