Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContainerRegistry] new swagger #17790

Merged
merged 4 commits into from
Apr 5, 2021

Conversation

seankane-msft
Copy link
Member

No description provided.

@seankane-msft seankane-msft added Container Registry Client This issue points to a problem in the data-plane of the library. labels Apr 5, 2021
@seankane-msft seankane-msft self-assigned this Apr 5, 2021
@seankane-msft seankane-msft marked this pull request as draft April 5, 2021 15:35
@seankane-msft seankane-msft marked this pull request as ready for review April 5, 2021 16:12
"""Set the properties for a tag

:param tag: Tag to set properties for
:type tag: str
:param permissions: The property's values to be set
:type permissions: ContentPermissions
:returns: None
:raises: None
:returns: TagProperties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be ~azure.containerregistry.TagProperties?

Comment on lines 195 to 196
:returns: None
:raises: None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these (and the return/raise types for set_manifest_properties) need an update like the sync client got

@seankane-msft seankane-msft merged commit cff7650 into Azure:master Apr 5, 2021
@seankane-msft seankane-msft deleted the acr-new-swagger branch April 5, 2021 17:53
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 11, 2022
Add x-ms-identifiers to webpubsub/resource-manager. (Azure#17790)

Co-authored-by: Steven Vukelich <svukel@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants