Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] rename package/namespace #17792

Merged

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Apr 5, 2021

Resolves #17043

This renames our package from azure-ai-documenttranslation to azure-ai-translation-document and places the code in the sdk/translation directory. It also adds a namespace package for azure-ai-translation-nspkg.

@Azure Azure deleted a comment from check-enforcer bot Apr 5, 2021
@kristapratico
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Apr 5, 2021
@kristapratico
Copy link
Member Author

/azp run python - translation - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renames and structure LGTM

@kristapratico
Copy link
Member Author

/azp run python - translation - ci

@kristapratico
Copy link
Member Author

/azp run python - translation - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -1,4 +1,5 @@
azure-ai-nspkg
azure-ai-translation-nspkg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why is this not listed for TA or FR?

@kristapratico
Copy link
Member Author

/azp run python - translation - ci

@kristapratico
Copy link
Member Author

/azp run python - translation - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kristapratico
Copy link
Member Author

/azp run python - translation - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kristapratico
Copy link
Member Author

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kristapratico kristapratico merged commit 0523eab into Azure:master Apr 5, 2021
@kristapratico kristapratico deleted the rename-translation-documents branch April 5, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[translation] Resolve namespace
3 participants