Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContainerRegistry] ACR orderby #17794

Merged
merged 5 commits into from
Apr 5, 2021
Merged

Conversation

seankane-msft
Copy link
Member

No description provided.

@seankane-msft seankane-msft added Container Registry Client This issue points to a problem in the data-plane of the library. labels Apr 5, 2021
@seankane-msft seankane-msft self-assigned this Apr 5, 2021
Comment on lines 196 to 197
:returns: None
:raises: None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raises and/or return type seems to be missing here

Comment on lines 179 to 180
:returns: None
:raises: None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raises and/or return type seems to be missing here (type hint as well)

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments were addressed in another PR and the rest looks good!

@seankane-msft seankane-msft merged commit 53033f2 into Azure:master Apr 5, 2021
@seankane-msft seankane-msft deleted the acr-orderby branch April 5, 2021 21:41
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 2, 2022
Add x-ms-identifiers to storageimportexport/resource-manager. (Azure#17794)

Co-authored-by: Steven Vukelich <svukel@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants