-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tables] Fix for async retry policy #17810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, otherwise LGTM
callback = ResponseCallback(status=201, new_status=408).override_status | ||
|
||
try: | ||
# The initial create will return 201, but we overwrite it and retry. | ||
# The retry will then get a 409 and return false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the callback says new_status=408
but your comment says the retry is a 409
, just for clarification is it expecing a 408 or 409?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually both - I will update the comments to be clearer.
/azp run python - tables - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
[Azure Data Factory] Support rest-based connectors in ADF (I) (Azure#17810) * Enable excel in public swagger * update * rollback dataflow change * Support rest-based connectors in ADF (I) * update * Update Co-authored-by: zhanyu2014 <zhanyu@microsoft.com>
No description provided.