Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Container Registry] Test fixes #17847

Merged
5 commits merged into from
Apr 7, 2021
Merged

[Container Registry] Test fixes #17847

5 commits merged into from
Apr 7, 2021

Conversation

seankane-msft
Copy link
Member

Fixing the environment variables in tests to work with the pipeline.

@check-enforcer
Copy link

check-enforcer bot commented Apr 7, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@ghost
Copy link

ghost commented Apr 7, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@seankane-msft
Copy link
Member Author

/check-enforcer reset

@seankane-msft
Copy link
Member Author

/azp run python - containerregistry - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost merged commit 379a23f into Azure:master Apr 7, 2021
@seankane-msft seankane-msft deleted the pre-release branch April 8, 2021 11:40
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 9, 2021
Fixing the environment variables in tests to work with the pipeline.
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 13, 2021
Fixing the environment variables in tests to work with the pipeline.
benbp pushed a commit to benbp/azure-sdk-for-python that referenced this pull request Apr 19, 2021
Fixing the environment variables in tests to work with the pipeline.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants